diff mbox

[-next] ixgbe: Fix non static symbol warnings

Message ID 1471964842-335-1-git-send-email-weiyj.lk@gmail.com
State Rejected
Headers show

Commit Message

Wei Yongjun Aug. 23, 2016, 3:07 p.m. UTC
From: Wei Yongjun <weiyongjun1@huawei.com>

Fixes the following sparse warnings:

drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2128:5: warning:
 symbol 'ixgbe_led_on_t_x550em' was not declared. Should it be static?
drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2150:5: warning:
 symbol 'ixgbe_led_off_t_x550em' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Emil Tantilov Aug. 23, 2016, 5:18 p.m. UTC | #1
>-----Original Message-----
>From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.org] On
>Behalf Of Wei Yongjun
>Sent: Tuesday, August 23, 2016 8:07 AM
>To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
>Cc: intel-wired-lan@lists.osuosl.org; Wei Yongjun <weiyongjun1@huawei.com>;
>netdev@vger.kernel.org
>Subject: [Intel-wired-lan] [PATCH -next] ixgbe: Fix non static symbol
>warnings
>
>From: Wei Yongjun <weiyongjun1@huawei.com>
>
>Fixes the following sparse warnings:
>
>drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2128:5: warning:
> symbol 'ixgbe_led_on_t_x550em' was not declared. Should it be static?
>drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2150:5: warning:
> symbol 'ixgbe_led_off_t_x550em' was not declared. Should it be static?
>
>Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Already resolved:
http://patchwork.ozlabs.org/patch/661647/

Thanks,
Emil
diff mbox

Patch

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
index fb1b819..417913e 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
@@ -2125,7 +2125,7 @@  static s32 ixgbe_reset_phy_t_X550em(struct ixgbe_hw *hw)
  *  @hw: pointer to hardware structure
  *  @led_idx: led number to turn on
  **/
-s32 ixgbe_led_on_t_x550em(struct ixgbe_hw *hw, u32 led_idx)
+static s32 ixgbe_led_on_t_x550em(struct ixgbe_hw *hw, u32 led_idx)
 {
 	u16 phy_data;
 
@@ -2147,7 +2147,7 @@  s32 ixgbe_led_on_t_x550em(struct ixgbe_hw *hw, u32 led_idx)
  *  @hw: pointer to hardware structure
  *  @led_idx: led number to turn off
  **/
-s32 ixgbe_led_off_t_x550em(struct ixgbe_hw *hw, u32 led_idx)
+static s32 ixgbe_led_off_t_x550em(struct ixgbe_hw *hw, u32 led_idx)
 {
 	u16 phy_data;