diff mbox

[next,S20,10/15] i40e: fix confusing message

Message ID 1445903081-155893-11-git-send-email-catherine.sullivan@intel.com
State Accepted
Delegated to: Jeff Kirsher
Headers show

Commit Message

Catherine Sullivan Oct. 26, 2015, 11:44 p.m. UTC 
From: Helin Zhang <helin.zhang@intel.com>

This patch fixes the confusing kernel message of enabled RSS size,
by reporting it together with the hardware maximum RSS size.

Signed-off-by: Helin Zhang <helin.zhang@intel.com>
Change-ID: I64864dbfbc13beccc180a7871680def1f3d5a339

---
Testing-hints: Check for "RSS count/HW max RSS count" in dmesg when the
RSS size is changed through "ethtool -l ethx", especially when the
number of queues are brought down.
 drivers/net/ethernet/intel/i40e/i40e_main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Bowers, AndrewX Oct. 28, 2015, 9:32 p.m. UTC | #1 
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.org] On
> Behalf Of Catherine Sullivan
> Sent: Monday, October 26, 2015 4:45 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Zhang, Helin
> Subject: [Intel-wired-lan] [next PATCH S20 10/15] i40e: fix confusing message
> 
> From: Helin Zhang <helin.zhang@intel.com>
> 
> This patch fixes the confusing kernel message of enabled RSS size, by
> reporting it together with the hardware maximum RSS size.
> 
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> Change-ID: I64864dbfbc13beccc180a7871680def1f3d5a339
> 
> ---
> Testing-hints: Check for "RSS count/HW max RSS count" in dmesg when the
> RSS size is changed through "ethtool -l ethx", especially when the number of
> queues are brought down.
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Patch code changes correctly applied, updated message appears in dmesg when changing RSS queue size.
diff mbox

Patch

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 508cf9a..4e9d6e5 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -8110,7 +8110,8 @@  int i40e_reconfig_rss_queues(struct i40e_pf *pf, int queue_count)
 
 		i40e_pf_config_rss(pf);
 	}
-	dev_info(&pf->pdev->dev, "RSS count:  %d\n", pf->alloc_rss_size);
+	dev_info(&pf->pdev->dev, "RSS count/HW max RSS count:  %d/%d\n",
+		 pf->alloc_rss_size, pf->rss_size_max);
 	return pf->alloc_rss_size;
 }