| Message ID | 1444863479-31570-1-git-send-email-xerofoify@gmail.com |
|---|---|
| State | Rejected |
| Headers | show |
On Wed, 2015-10-14 at 18:57 -0400, Nicholas Krause wrote: > This removes the reducant error path and now no longer used goto > label err_sw_init after the call to ixgb_probe in the function > ixgb_sw_init after calling this function due to it always returning > zero as it is guarantee to run successfully without any issues. > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com> > --- > drivers/net/ethernet/intel/ixgb/ixgb_main.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) This driver (ixgb), as well as e100 and e1000 are in maintenance mode which means bug fixes ONLY! Is this patch necessary? Answer: No Is this a bug fix? Answer: No Should you have sent this patch? See answers to previous questions. Please ask these questions to yourself when putting together a patch against these drivers (listed above). With that said, dropping this series.
On 2015-10-14 09:23 PM, Jeff Kirsher wrote: > On Wed, 2015-10-14 at 18:57 -0400, Nicholas Krause wrote: >> This removes the reducant error path and now no longer used goto >> label err_sw_init after the call to ixgb_probe in the function >> ixgb_sw_init after calling this function due to it always returning >> zero as it is guarantee to run successfully without any issues. >> >> Signed-off-by: Nicholas Krause <xerofoify@gmail.com> >> --- >> drivers/net/ethernet/intel/ixgb/ixgb_main.c | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) > > This driver (ixgb), as well as e100 and e1000 are in maintenance mode > which means bug fixes ONLY! > > Is this patch necessary? Answer: No > Is this a bug fix? Answer: No > Should you have sent this patch? See answers to previous questions. > > Please ask these questions to yourself when putting together a patch > against these drivers (listed above). > > With that said, dropping this series. > Sorry Jeff, I was not aware that these drivers are in maintenance only mode and therefore thought this OK. Nick
diff --git a/drivers/net/ethernet/intel/ixgb/ixgb_main.c b/drivers/net/ethernet/intel/ixgb/ixgb_main.c index 31f9145..4a90f36 100644 --- a/drivers/net/ethernet/intel/ixgb/ixgb_main.c +++ b/drivers/net/ethernet/intel/ixgb/ixgb_main.c @@ -469,9 +469,7 @@ ixgb_probe(struct pci_dev *pdev, const struct pci_device_id *ent) /* setup the private structure */ - err = ixgb_sw_init(adapter); - if (err) - goto err_sw_init; + ixgb_sw_init(adapter); netdev->hw_features = NETIF_F_SG | NETIF_F_TSO | @@ -531,7 +529,6 @@ ixgb_probe(struct pci_dev *pdev, const struct pci_device_id *ent) return 0; err_register: -err_sw_init: err_eeprom: iounmap(adapter->hw.hw_addr); err_ioremap:
This removes the reducant error path and now no longer used goto label err_sw_init after the call to ixgb_probe in the function ixgb_sw_init after calling this function due to it always returning zero as it is guarantee to run successfully without any issues. Signed-off-by: Nicholas Krause <xerofoify@gmail.com> --- drivers/net/ethernet/intel/ixgb/ixgb_main.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)