diff mbox

[net-next] e100: don't initialize int object to zero

Message ID 1428273124-14321-1-git-send-email-sakiwit@gmail.com
State Accepted
Delegated to: Jeff Kirsher
Headers show

Commit Message

Jean Sacren April 5, 2015, 10:32 p.m. UTC
From: Jean Sacren <sakiwit@gmail.com>

'err' will be overwritten so no need to initialize it to zero.

Signed-off-by: Jean Sacren <sakiwit@gmail.com>
---
 drivers/net/ethernet/intel/e100.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kirsher, Jeffrey T April 7, 2015, 10:59 p.m. UTC | #1
On Sun, 2015-04-05 at 16:32 -0600, Jεan Sacren wrote:
> From: Jean Sacren <sakiwit@gmail.com>
> 
> 'err' will be overwritten so no need to initialize it to zero.
> 
> Signed-off-by: Jean Sacren <sakiwit@gmail.com>
> ---
>  drivers/net/ethernet/intel/e100.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks Jean, I have applied your patch to my queue.
Brown, Aaron F April 16, 2015, 3:59 a.m. UTC | #2
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.org] On

> Behalf Of Jeff Kirsher

> Sent: Tuesday, April 07, 2015 3:59 PM

> To: Jεan Sacren

> Cc: intel-wired-lan@lists.osuosl.org

> Subject: Re: [Intel-wired-lan] [net-next] e100: don't initialize int

> object to zero

> 

> On Sun, 2015-04-05 at 16:32 -0600, Jεan Sacren wrote:

> > From: Jean Sacren <sakiwit@gmail.com>

> >

> > 'err' will be overwritten so no need to initialize it to zero.

> >

> > Signed-off-by: Jean Sacren <sakiwit@gmail.com>

> > ---

> >  drivers/net/ethernet/intel/e100.c | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> Thanks Jean, I have applied your patch to my queue.

> --

> git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git

> dev-queue


Tested-by: Aaron Brown <aaron.f.brown@intel.com>
diff mbox

Patch

diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c
index 05f88394f9a5..75a11ea7a9d6 100644
--- a/drivers/net/ethernet/intel/e100.c
+++ b/drivers/net/ethernet/intel/e100.c
@@ -874,7 +874,7 @@  static int e100_exec_cb(struct nic *nic, struct sk_buff *skb,
 {
 	struct cb *cb;
 	unsigned long flags;
-	int err = 0;
+	int err;
 
 	spin_lock_irqsave(&nic->cb_lock, flags);