mbox series

[jkirsher/next-queue,0/5] macvlan offload fixes

Message ID 20171102232857.15146.21583.stgit@localhost.localdomain
Headers show
Series macvlan offload fixes | expand

Message

Alexander Duyck Nov. 2, 2017, 11:33 p.m. UTC
I'm looking at performing a refactor of the macvlan offload code. However
before I started I wanted to at least get things into a running state. The
patches in this set are needed to address a number of issues that were
preventing things from working as they were supposed to.

With these changes in place I seem to be able to receive traffic as I am
supposed to in the case of ixgbe and fm10k with the offload enabled, and I
am now transmitting to the correct Tx ring in the case of ixgbe.

The last two patches in the set are what I consider to be minor clean-ups
to address the fact that we don't want packets to somehow stray and end up
being transmitted on a queue that is supposed to be in use by a macvlan
instead of the lowerdev itself.

---

Alexander Duyck (5):
      ixgbe: Fix interaction between SR-IOV and macvlan offload
      fm10k: Fix VLAN configuration for macvlan offload
      ixgbe: Fix handling of macvlan Tx offload
      dev: Clean-up __skb_tx_hash to match up with traffic class based configs
      dev: Cap number of queues even with accel_priv


 drivers/net/ethernet/intel/fm10k/fm10k_netdev.c |    4 ++--
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c   |   22 ++++++++++++++++++----
 net/core/dev.c                                  |   21 ++++++++++-----------
 3 files changed, 30 insertions(+), 17 deletions(-)

--

Comments

Shannon Nelson Nov. 3, 2017, 5:13 p.m. UTC | #1
On 11/2/2017 4:33 PM, Alexander Duyck wrote:
> I'm looking at performing a refactor of the macvlan offload code. However
> before I started I wanted to at least get things into a running state. The
> patches in this set are needed to address a number of issues that were
> preventing things from working as they were supposed to.
> 
> With these changes in place I seem to be able to receive traffic as I am
> supposed to in the case of ixgbe and fm10k with the offload enabled, and I
> am now transmitting to the correct Tx ring in the case of ixgbe.
> 
> The last two patches in the set are what I consider to be minor clean-ups
> to address the fact that we don't want packets to somehow stray and end up
> being transmitted on a queue that is supposed to be in use by a macvlan
> instead of the lowerdev itself.

Other than the little misspelling I flagged,
Acked-by: Shannon Nelson <shannon.nelson@oracle.com>

> 
> ---
> 
> Alexander Duyck (5):
>        ixgbe: Fix interaction between SR-IOV and macvlan offload
>        fm10k: Fix VLAN configuration for macvlan offload
>        ixgbe: Fix handling of macvlan Tx offload
>        dev: Clean-up __skb_tx_hash to match up with traffic class based configs
>        dev: Cap number of queues even with accel_priv
> 
> 
>   drivers/net/ethernet/intel/fm10k/fm10k_netdev.c |    4 ++--
>   drivers/net/ethernet/intel/ixgbe/ixgbe_main.c   |   22 ++++++++++++++++++----
>   net/core/dev.c                                  |   21 ++++++++++-----------
>   3 files changed, 30 insertions(+), 17 deletions(-)
> 
> --
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
>