diff mbox

wpa_supplicant: typo in wpa_scan_result_compar

Message ID EC18CD4F248FCC49B53632D772F729D6263901C2@DFRE01.ent.ti.com
State Accepted
Headers show

Commit Message

Hahn, Maital July 8, 2015, 1:13 p.m. UTC 
Typo in wpa_scan_result_compar() causes wrong scan results sorting
(and wrong roaming decision)

Signed-off-by: Maital Hahn <maitalm@ti.com>
---
 wpa_supplicant/scan.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
 mode change 100644 => 100755 wpa_supplicant/scan.c

--
1.7.9

-----Original Message-----
From: Jouni Malinen [mailto:j@w1.fi] 
Sent: Wednesday, July 08, 2015 3:36 PM
To: Hahn, Maital
Cc: hostap@lists.shmoo.com
Subject: Re: wpa_supplicant: typo in wpa_scan_result_compar() causes wrong scan results sorting (and wrong roaming decision)

On Wed, Jul 08, 2015 at 11:26:53AM +0000, Hahn, Maital wrote:
> diff --git a/wpa_supplicant/scan.c b/wpa_supplicant/scan.c
> --- a/wpa_supplicant/scan.c
> +++ b/wpa_supplicant/scan.c
> @@ -1717,7 +1717,7 @@ static int wpa_scan_result_compar(const void *a, 
> const void *b)

Could you please read the top level CONTRIBUTIONS file and send this with a Signed-off-by: line in the commit message as described in that file so that I can apply the changes?

Comments

Jouni Malinen July 8, 2015, 2:43 p.m. UTC | #1 
On Wed, Jul 08, 2015 at 01:13:11PM +0000, Hahn, Maital wrote:
> Typo in wpa_scan_result_compar() causes wrong scan results sorting
> (and wrong roaming decision)

Thanks, applied.
diff mbox

Patch

diff --git a/wpa_supplicant/scan.c b/wpa_supplicant/scan.c
old mode 100644
new mode 100755
index b429951..6e39c2a
--- a/wpa_supplicant/scan.c
+++ b/wpa_supplicant/scan.c
@@ -1717,7 +1717,7 @@  static int wpa_scan_result_compar(const void *a, const void *b)
                snr_a_full = wa->snr;
                snr_a = MIN(wa->snr, GREAT_SNR);
                snr_b_full = wb->snr;
-               snr_b = MIN(wa->snr, GREAT_SNR);
+               snr_b = MIN(wb->snr, GREAT_SNR);
        } else {
                /* Level is not in dBm, so we can't calculate
                 * SNR. Just use raw level (units unknown). */