diff mbox series

Fix sending NL80211_CMD_DEL_BEACON command to wrong interface

Message ID CY8PR19MB72520E3A9225C36D33C98866DB242@CY8PR19MB7252.namprd19.prod.outlook.com
State Accepted
Headers show
Series Fix sending NL80211_CMD_DEL_BEACON command to wrong interface | expand

Commit Message

Nikita Chernikov March 11, 2024, 5:04 p.m. UTC 
From 1183aeff28f7bf8f9290dbe08d8c17b6d741b0c9 Mon Sep 17 00:00:00 2001
From: Nikita Chernikov <nchernikov@maxlinear.com>
Date: Mon, 11 Mar 2024 18:58:21 +0200
Subject: [PATCH] Fix sending NL80211_CMD_DEL_BEACON command to wrong interface
To: hostap@lists.infradead.org

Currently NL80211_CMD_DEL_BEACON command is always sent to master interface of the radio instead of the desired bss interface.
i.e. when sending STOP_AP ctrl interface command from upper layer.

Signed-off-by: Nikita Chernikov <nchernikov@maxlinear.com>
---
 src/drivers/driver_nl80211.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jouni Malinen March 23, 2024, 8:26 p.m. UTC | #1 
On Mon, Mar 11, 2024 at 05:04:44PM +0000, Nikita Chernikov wrote:
> Currently NL80211_CMD_DEL_BEACON command is always sent to master interface of the radio instead of the desired bss interface.
> i.e. when sending STOP_AP ctrl interface command from upper layer.

Thanks, applied.
diff mbox series

Patch

diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
index b3e9e6f2f..8cdd21fa1 100644
--- a/src/drivers/driver_nl80211.c
+++ b/src/drivers/driver_nl80211.c
@@ -3078,12 +3078,12 @@  static int wpa_driver_nl80211_del_beacon(struct i802_bss *bss,
 		return 0;
 
 	wpa_printf(MSG_DEBUG, "nl80211: Remove beacon (ifindex=%d)",
-		   drv->ifindex);
+		   bss->ifindex);
 	link->beacon_set = 0;
 	link->freq = 0;
 
 	nl80211_put_wiphy_data_ap(bss);
-	msg = nl80211_drv_msg(drv, 0, NL80211_CMD_DEL_BEACON);
+	msg = nl80211_ifindex_msg(drv, bss->ifindex, 0, NL80211_CMD_DEL_BEACON);
 	if (!msg)
 		return -ENOBUFS;