From patchwork Sun Jan 24 11:38:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Lowe X-Patchwork-Id: 572234 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id E4CAC140326 for ; Sun, 24 Jan 2016 22:38:51 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=lugatech-com.20150623.gappssmtp.com header.i=@lugatech-com.20150623.gappssmtp.com header.b=Oh29mto3; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aNJ0H-0004t0-26; Sun, 24 Jan 2016 11:38:45 +0000 Received: from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aNJ0F-0004ps-7e for hostap@lists.infradead.org; Sun, 24 Jan 2016 11:38:43 +0000 Received: by mail-wm0-x22f.google.com with SMTP id r129so33345568wmr.0 for ; Sun, 24 Jan 2016 03:38:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lugatech-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=dl+7crdgdYEAGTpoHYdhbViPKzNwqbYfEE8R1tQPT8E=; b=Oh29mto3Fbf7EwREWMRRrFg+PyqaRUza+t8fzYxK3tHoDDP1Hr2r71kvO6dZzUB2AN j9YC46m2ssqw0ZytQv1FClUbF//ynp+uVBASHneB+JIMT2EFjSnxHQML/eMtryyuEheT z4jsq4620bSOKIvIOQg2H/CvM0r4usVIoPcjZAwefrR0YMXWvvPgWTPhkYvjv2iRO2Lk IC1isHbs0c6Voo2EedKHXP/jcB35GZIPVzi5bnA2qsIXQ5ABRXTttr+gS7M0bkS2i2+W 0xfTGFT+DELM4/S5FyAQsUbZej06u9KQA1nNEzbyqCrtpW+dJtqtdCzRgUcoG03gq6te oOGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=dl+7crdgdYEAGTpoHYdhbViPKzNwqbYfEE8R1tQPT8E=; b=me2P8k+sLJIERVcgVuP+bgdm8kMiCL6nrnfbMXup+0vLHpXPA4V7PirbRmwIY/ypo/ HflsGA28xctT2m2xbPVoaFikt2Ak8KGcy1U0o+HoKcV5tvpY6PoMTnlRYiIlGBO8hRCu ljvZ5cWz2Bq4ex6IAJDkLvnWdMuQ+TFajIW2UzQsm4wLgHeRgojbHVx5yqagtAAtfaGF UypuGdgtCtpeJopLo56MLBNEUDIKuENG05+kSzZRIFMnvvLBC357vJawS2LWshrigpau UyEis2osJ3+ottN/nw/jwB8IGa9XuZ9GS70nI7TUKpajfFtDxQrbtzMVtapvgYQWSfPI EQoQ== X-Gm-Message-State: AG10YOTOZrn8xJ7KPK7jNo7N3BFLYVJE+dy8y8RAL8N3fNxWhxI5V8aO5841e5W5htLO0+WFLXvH7wQ9qLHC2g== MIME-Version: 1.0 X-Received: by 10.194.117.169 with SMTP id kf9mr12098014wjb.122.1453635502020; Sun, 24 Jan 2016 03:38:22 -0800 (PST) Received: by 10.28.104.133 with HTTP; Sun, 24 Jan 2016 03:38:21 -0800 (PST) X-Originating-IP: [77.96.75.177] In-Reply-To: References: Date: Sun, 24 Jan 2016 11:38:21 +0000 Message-ID: Subject: Re: [PATCH] It is invalid to send Acct-Terminate-Cause in Accounting-On and Accounting-Off From: Nick Lowe To: hostap@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160124_033843_428794_8617796E X-CRM114-Status: GOOD ( 10.19 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2a00:1450:400c:c09:0:0:0:22f listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Attached without the whitespace broken... From b169a2269b8f3422a73ba9100085de8100eab89f Mon Sep 17 00:00:00 2001 From: Nick Lowe Date: Sun, 24 Jan 2016 10:20:33 +0000 Subject: [PATCH 2/3] It is invalid to send Acct-Terminate-Cause in Accounting-On and Accounting-Off. Signed-off-by: Nick Lowe --- src/ap/accounting.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/ap/accounting.c b/src/ap/accounting.c index 95dc366..e585b78 100644 --- a/src/ap/accounting.c +++ b/src/ap/accounting.c @@ -448,14 +448,6 @@ static void accounting_report_state(struct hostapd_data *hapd, int on) if (!msg) return; - if (!radius_msg_add_attr_int32(msg, RADIUS_ATTR_ACCT_TERMINATE_CAUSE, - RADIUS_ACCT_TERMINATE_CAUSE_NAS_REBOOT)) - { - wpa_printf(MSG_INFO, "Could not add Acct-Terminate-Cause"); - radius_msg_free(msg); - return; - } - if (radius_client_send(hapd->radius, msg, RADIUS_ACCT, NULL) < 0) radius_msg_free(msg); } -- 2.5.0