diff mbox series

Fix: hapd->dpp_auth is unallocated when receiving a DPP Prescence Announcement causing a segmentation fault.

Message ID CA+XRdEAr1NAdQM_PEcXYpQ__D6xnyyBQ6effczPPNuduTMdwpQ@mail.gmail.com
State Superseded
Headers show
Series Fix: hapd->dpp_auth is unallocated when receiving a DPP Prescence Announcement causing a segmentation fault. | expand

Commit Message

Wystan Schmidt Oct. 6, 2020, 6:50 p.m. UTC
Signed-off-by: Wystan Schmidt <wystan.schmidt@charter.com>
---
 src/ap/dpp_hostapd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

                return;
--
2.18.0

Comments

Wystan Schmidt Oct. 6, 2020, 9:03 p.m. UTC | #1
This is a duplicate of
http://lists.infradead.org/pipermail/hostap/2020-September/038845.html


On Tue, Oct 6, 2020 at 12:50 PM Wystan Schmidt <wystans@gmail.com> wrote:
>
> Signed-off-by: Wystan Schmidt <wystan.schmidt@charter.com>
> ---
>  src/ap/dpp_hostapd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/ap/dpp_hostapd.c b/src/ap/dpp_hostapd.c
> index 15aa82b85..2a28239e1 100644
> --- a/src/ap/dpp_hostapd.c
> +++ b/src/ap/dpp_hostapd.c
> @@ -1249,8 +1249,8 @@ hostapd_dpp_rx_presence_announcement(struct
> hostapd_data *hapd, const u8 *src,
>                              0);
>         if (!auth)
>                 return;
> -       hostapd_dpp_set_testing_options(hapd, hapd->dpp_auth);
> -       if (dpp_set_configurator(hapd->dpp_auth,
> +       hostapd_dpp_set_testing_options(hapd, auth);
> +       if (dpp_set_configurator(auth,
>                                  hapd->dpp_configurator_params) < 0) {
>                 dpp_auth_deinit(auth);
>                 return;
> --
> 2.18.0
diff mbox series

Patch

diff --git a/src/ap/dpp_hostapd.c b/src/ap/dpp_hostapd.c
index 15aa82b85..2a28239e1 100644
--- a/src/ap/dpp_hostapd.c
+++ b/src/ap/dpp_hostapd.c
@@ -1249,8 +1249,8 @@  hostapd_dpp_rx_presence_announcement(struct
hostapd_data *hapd, const u8 *src,
                             0);
        if (!auth)
                return;
-       hostapd_dpp_set_testing_options(hapd, hapd->dpp_auth);
-       if (dpp_set_configurator(hapd->dpp_auth,
+       hostapd_dpp_set_testing_options(hapd, auth);
+       if (dpp_set_configurator(auth,
                                 hapd->dpp_configurator_params) < 0) {
                dpp_auth_deinit(auth);