Message ID | 833617682.1134241452857463524.JavaMail.weblogic@ep2mlwas08a |
---|---|
State | Accepted |
Headers | show
Return-Path: <hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id CEE371401DE for <incoming@patchwork.ozlabs.org>; Fri, 15 Jan 2016 22:31:35 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aK2bI-0001aq-HU; Fri, 15 Jan 2016 11:31:28 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aK2bF-0001VA-UM for hostap@lists.infradead.org; Fri, 15 Jan 2016 11:31:27 +0000 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O0Z02P1RRZRU9D0@mailout2.samsung.com> for hostap@lists.infradead.org; Fri, 15 Jan 2016 20:31:03 +0900 (KST) Received: from epcpsbgx1.samsung.com ( [172.20.52.122]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 24.78.04790.778D8965; Fri, 15 Jan 2016 20:31:03 +0900 (KST) X-AuditID: cbfee691-f79766d0000012b6-2f-5698d8777aa4 Received: from epmailer02 ( [203.254.219.142]) by epcpsbgx1.samsung.com (EPCPMTA) with SMTP id 95.74.05140.778D8965; Fri, 15 Jan 2016 20:31:03 +0900 (KST) Date: Fri, 15 Jan 2016 11:31:03 +0000 (GMT) From: Purushottam Kushwaha <p.kushwaha@samsung.com> Subject: [PATCH] Avoid Potential memory leak. To: hostap@lists.infradead.org MIME-version: 1.0 X-MTR: 20160115112732445@p.kushwaha Msgkey: 20160115112732445@p.kushwaha X-EPLocale: en_US.windows-1252 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20160115112732445@p.kushwaha X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general MIME-version: 1.0 Message-id: <833617682.1134241452857463524.JavaMail.weblogic@ep2mlwas08a> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrIIsWRmVeSWpSXmKPExsWyRsSkSrf8xowwg8srtCzWPkpzYPTYvKQ+ gDGKyyYlNSezLLVI3y6BK+PI/geMBUvYK5pfPmZqYOxg72Lk5BASUJWY87gXzJYQMJGYPPEN lC0mceHeerYuRi6gmqWMEs97uxlhimZNusAC0TyHUWL7fq8uRg4OFqBBm1aXg4TZgErWHehh BbGFBXQlXt5fxQxSIiKgLPF8vw9ImFlAR+Js73RmiCkKEnd6poCt5RUQlDg58wkLxCZliTcH L7OCtPIKqEjcnc8BEZaTWDL1MhOEzSsxo/0pC0x82tc1zBC2tMT5WRsYYT5Z/P0xVJxf4tjt HVC9AhJTzxyEqtGQ2Np8EqqGT2LNwrcsMPW7Ti1nhtl1f8tcqF4Jia0tT1ghXlGUmNL9kB3C NpA4smgOK7pXeAU8JR69eQ4OTQmBVg6JPTePsU5gVJqFpG4WklmzkMxCVrOAkWUVo2hqQXJB cVJ6kalecWJucWleul5yfu4mRmBKOP3v2cQdjPcPWB9iFOBgVOLhDeCZESbEmlhWXJl7iNEU GEkTmaVEk/OBiSevJN7Q2MzIwtTE1NjI3NJMSZxXR/pnsJBAemJJanZqakFqUXxRaU5q8SFG Jg5OqQZGZa+2WVcVnT6fcIo4fc+x5dMqnvs7Snt2Je8pPJj60++RVO4RThvjIz8v1E28Knho 9Sb7PYuevL1663OcdatSc1/2Sf7o3TkmB7xZFx8LWx5h0bKjumbSF9nW5MnTzVdGtQvc5v86 XTjwq9e2CT2vFnhOKpzJ9/X03oLn7tpiSzznLXn0cvLcFCWW4oxEQy3mouJEABYSxpwEAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrEKsWRmVeSWpSXmKPExsVy+t/tPt3yGzPCDGY1KFusfZTmwOixeUl9 AGNUmk1GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0Ewl hbLEnFKgUEBicbGSvp1NUX5pSapCRn5xia1StKG5kZ6RgZ6pkZ6haayVoYGBkSlQTUJaxpH9 DxgLlrBXNL98zNTA2MHexcjJISSgKjHncS+YLSFgIjFr0gUWCFtM4sK99WwQNXMYJbbv9+pi 5OBgAarftLocJMwGVL7uQA8riC0soCvx8v4qZpASEQFlief7fUDCzAI6Emd7pzNDTFGQuNMz BWwTr4CgxMmZT6A2KUu8OXiZFaSVV0BF4u58DoiwnMSSqZeZIGxeiRntT1lg4tO+rmGGsKUl zs/awAhz8OLvj6Hi/BLHbu+A6hWQmHrmIFSNhsTW5pNQNXwSaxa+ZYGp33VqOTPMrvtb5kL1 SkhsbXnCCvGKosSU7ofsELaBxJFFc1jRvcIr4Cnx6M1ztgmMsrOQpGYhaZ+FpB1ZzQJGllWM oqkFyQXFSekVhnrFibnFpXnpesn5uZsYwenn2cIdjF/OWx9iFOBgVOLhDeCZESbEmlhWXJl7 iFGCg1lJhDf6OlCINyWxsiq1KD++qDQntfgQoykwyiYyS4km5wNTY15JvKGxibmpsamFgaG5 uZmSOO/tfX5hQgLpiSWp2ampBalFMH1MHJxSDYyVQVzfPjD9YFxVYRhZ88N9UqBAwK70eSfz LfkmznBaGuRVtPj0z57pS9cUyLgZXi0pD5kwT0yD68uWh/YHNGLt7m/3DX33VfXdtLyQ+4yd x1sEyjN+8F7nczznvPBo0BXzSw81a+3+O037GLV9a9oOzRj7C2onGrlKpOvdfr4q/vqw/dgU FXclluKMREMt5qLiRABKkmNBVQMAAA== DLP-Filter: Pass X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160115_033126_210353_34DB0776 X-CRM114-Status: UNSURE ( 9.09 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -6.9 (------) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-6.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [203.254.224.25 listed in list.dnswl.org] -0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [203.254.224.25 listed in wl.mailspike.net] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: <hostap.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/hostap>, <mailto:hostap-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/hostap/> List-Post: <mailto:hostap@lists.infradead.org> List-Help: <mailto:hostap-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/hostap>, <mailto:hostap-request@lists.infradead.org?subject=subscribe> Reply-To: p.kushwaha@samsung.com Cc: Kaushik Saha <kaushik.s14@samsung.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Hostap" <hostap-bounces@lists.infradead.org> Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
On Fri, Jan 15, 2016 at 11:31:03AM +0000, Purushottam Kushwaha wrote:
> Called function [nl80211_ht_vht_overrides()] is not freeing "msg" resource in fail cases.
Thanks, applied.
diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c index cdd1504..5dead25 100644 --- a/src/drivers/driver_nl80211.c +++ b/src/drivers/driver_nl80211.c @@ -4549,8 +4549,8 @@ retry: goto fail; } - if (nl80211_ht_vht_overrides(msg, params) < 0) - return -1; + if ((ret = nl80211_ht_vht_overrides(msg, params)) < 0) + goto fail; ret = send_and_recv_msgs(drv, msg, NULL, NULL); msg = NULL;
Called function [nl80211_ht_vht_overrides()] is not freeing "msg" resource in fail cases. Signed-off-by: Purushottam Kushwaha <p.kushwaha@samsung.com> --- src/drivers/driver_nl80211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)