diff mbox series

DBUS: Use correct values for persistent group

Message ID 20240417122812.2015822-1-andrei.otcheretianski@intel.com
State Accepted
Headers show
Series DBUS: Use correct values for persistent group | expand

Commit Message

Andrei Otcheretianski April 17, 2024, 12:28 p.m. UTC 
DBUS lib expects "persistent" to be bool (0/1) and crashes otherwise.
Since persistent may also be 2 convert it to boolean.

Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
---
 wpa_supplicant/dbus/dbus_new.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jouni Malinen April 21, 2024, 9:08 a.m. UTC | #1 
On Wed, Apr 17, 2024 at 03:28:12PM +0300, Andrei Otcheretianski wrote:
> DBUS lib expects "persistent" to be bool (0/1) and crashes otherwise.
> Since persistent may also be 2 convert it to boolean.

Thanks, applied.
diff mbox series

Patch

diff --git a/wpa_supplicant/dbus/dbus_new.c b/wpa_supplicant/dbus/dbus_new.c
index 8bd6a9a43b..02107dc475 100644
--- a/wpa_supplicant/dbus/dbus_new.c
+++ b/wpa_supplicant/dbus/dbus_new.c
@@ -1663,7 +1663,7 @@  void wpas_dbus_signal_p2p_group_started(struct wpa_supplicant *wpa_s,
 					      wpa_s->dbus_new_path) ||
 	    !wpa_dbus_dict_append_string(&dict_iter, "role",
 					 client ? "client" : "GO") ||
-	    !wpa_dbus_dict_append_bool(&dict_iter, "persistent", persistent) ||
+	    !wpa_dbus_dict_append_bool(&dict_iter, "persistent", !!persistent) ||
 	    !wpa_dbus_dict_append_object_path(&dict_iter, "group_object",
 					      wpa_s->dbus_groupobj_path) ||
 	    (ip &&