From patchwork Mon Apr 8 13:07:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrei Otcheretianski X-Patchwork-Id: 1920841 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=aYIN20Jq; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=FCXrn0X8; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VCqD523S7z1yYf for ; Mon, 8 Apr 2024 23:08:53 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=THFckPpifSgRCALzthtJHtt7ecaozBEh0/VGUAfz5jY=; b=aYIN20Jq0Z4wsR ZCV7byrvqRS4+9xmd5VY/8Wxqr3Txone6u3BMHmE1ZLBmBu/M3b1Lyn9pE9zBlg6VsVswz7gAJcCy 5PNtsGCWZIqRWBF4Q2N+OJ++05mzOPUaGIT05nigaKp+3Y0QwUXinxEal/yXwM35Nz0aXTis4SQKz s0r78ZCNzoJF0cTvowkxPmd6yxEOmz+ufgVJsQiGTMJI7O7vgE71ftJ26JkDhZFUIUqSbrawqcJ3K h06L6Itto+WUUHqqlgQ/eQKOAlUt0pwyFFHTVq4bX+FOINc4ljr0aW8Ag7gMNq4kOkV7ixjnkbMV4 JrO350HbEzbrJGCE/Cgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtojk-0000000FdxX-2Wnw; Mon, 08 Apr 2024 13:08:36 +0000 Received: from mgamail.intel.com ([198.175.65.14]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtojb-0000000FduP-3N4s for hostap@lists.infradead.org; Mon, 08 Apr 2024 13:08:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712581707; x=1744117707; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nx34M8SAT8WU7np2ZSz9GF02m332sMHMnymd5xYqlQ8=; b=FCXrn0X8wxiSZFUM70T3WG1tGyHCPGy94fiemOeB+PtGGM/I/jRjtsmj dRl9BbhD8nAYUx7xKMvZJb0HkbY957cIThZOJbw0rfxO67Bqw8/ckA0Hh dytk49ryTjAxadPMFywqJfKGJKFaeTBStaGF/4PHkmjlzhBCFrymJicBL SH6Yz9jsMUbAEw8XXThSpG3sIzHOUu4fI6GPC+UjtHDiU2r4cvichdAPW a63AOlNr5t+WGa098JOzTMDNFMrN3Fklc4de1IwIjDyeOSr0DrrbC3Xst 0ON5D4A2RXzA9IdR5VoLjV5zkzwwlj/IC91sppPoG5rW/tcp7d0DaUfFb g==; X-CSE-ConnectionGUID: gCjQZETaSOKI0CSGHl0Cbw== X-CSE-MsgGUID: DgFpDtM2Seagp2jJNjHsLw== X-IronPort-AV: E=McAfee;i="6600,9927,11038"; a="11688892" X-IronPort-AV: E=Sophos;i="6.07,186,1708416000"; d="scan'208";a="11688892" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 06:08:27 -0700 X-CSE-ConnectionGUID: JrEJPMacSpCPbkmybYzoJA== X-CSE-MsgGUID: f0TySkSpQ2CiMRsX6HBq0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,186,1708416000"; d="scan'208";a="50868815" Received: from unknown (HELO WEIS0042.iil.intel.com) ([10.12.217.211]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 06:08:27 -0700 From: Andrei Otcheretianski To: hostap@lists.infradead.org Cc: Benjamin Berg Subject: [PATCH 6/7] ctrl_iface: allow sending ML probe without AP MLD ID Date: Mon, 8 Apr 2024 16:07:00 +0300 Message-ID: <20240408130701.531194-6-andrei.otcheretianski@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240408130701.531194-1-andrei.otcheretianski@intel.com> References: <20240408130701.531194-1-andrei.otcheretianski@intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240408_060828_051288_2D951DDC X-CRM114-Status: GOOD ( 12.10 ) X-Spam-Score: -2.4 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Benjamin Berg If one sends a probe request to a non-TX BSSID, then no AP MLD ID should be included in the request. Permit mld_id to be -1 so that it is not a required argument and can be left out. Content analysis details: (-2.4 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [198.175.65.14 listed in list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -1.5 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Benjamin Berg If one sends a probe request to a non-TX BSSID, then no AP MLD ID should be included in the request. Permit mld_id to be -1 so that it is not a required argument and can be left out. Signed-off-by: Benjamin Berg --- wpa_supplicant/ctrl_iface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wpa_supplicant/ctrl_iface.c b/wpa_supplicant/ctrl_iface.c index d0fda4cd9e..bc013ad995 100644 --- a/wpa_supplicant/ctrl_iface.c +++ b/wpa_supplicant/ctrl_iface.c @@ -12118,7 +12118,7 @@ static int wpas_ctrl_ml_probe(struct wpa_supplicant *wpa_s, char *cmd) } } - if (mld_id < 0 || is_zero_ether_addr(bssid)) { + if (is_zero_ether_addr(bssid)) { wpa_printf(MSG_DEBUG, "MLD: Failed parsing ML probe request arguments"); return -1;