From patchwork Thu Apr 4 10:52:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felix Fietkau X-Patchwork-Id: 1919742 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Nz/0YhjQ; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=nbd.name header.i=@nbd.name header.a=rsa-sha256 header.s=20160729 header.b=ickviOx+; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V9JP030Zmz23v3 for ; Thu, 4 Apr 2024 21:52:52 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m6LajKGWNEl9Wl7L3FHZ5fvpBZwgRv8hxr0ZI4OLSpE=; b=Nz/0YhjQPQ70Dr c1/OUGUeyZ8rlvfL0k+SyvWRGkHHVr42Eg8rFgTUGj1uOGQZ3uv2nXeKFjvS1Vh6qHyZ45UNcY+Db hFWKihEpXPMWdZH+PDjK/zQINwvU3epboMMMxxdzPgUP+9ONWCT5re1SDmY366YN4klPDTSHPv9+e IjrvUBvuX1AMWok+5BVVpIWmeFHx7T0Uk3HIyKL98mo9EM6ybki6VcTx8JuyiOsiDylVpEYAxmtaL eTfSQnDXHvEopiJIltm6o13R6kHuipEuPQYFlhYN8oAJA8F595U3L8G5rRHAtqoU2qbkg9XSlrSUm TD4Rr2tJiBUP61aqnq/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsKhs-00000002FKh-3rRY; Thu, 04 Apr 2024 10:52:32 +0000 Received: from nbd.name ([46.4.11.11]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsKhh-00000002FGl-01T7 for hostap@lists.infradead.org; Thu, 04 Apr 2024 10:52:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zdsMQYzgRaDLavsiTmjDEgn5UjjqCma6ahKJiZlaMPg=; b=ickviOx+587CfthW4jo68UsyGd R4L+9VjkI9NftgoutFoCi7qhsM3UPg6RGEzb2B1xhL38mNutQ3r0VzHPnFRu9Xr6wmkaSSGELpaW0 WfplfeXvOa4LL2PG6DUlwtW+MBiSRM4I8vL3vc9GPAta1Lz1HfSgcOmy4uQM5rfxY8Do=; Received: from p54ae9c93.dip0.t-ipconnect.de ([84.174.156.147] helo=localhost.localdomain) by ds12 with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 (Exim 4.94.2) (envelope-from ) id 1rsKhe-00CyWX-JL for hostap@lists.infradead.org; Thu, 04 Apr 2024 12:52:18 +0200 From: Felix Fietkau To: hostap@lists.infradead.org Subject: [PATCH 3/7] ndisc_snoop: call dl_list_del before freeing ipv6 addresses Date: Thu, 4 Apr 2024 12:52:13 +0200 Message-ID: <20240404105217.12478-3-nbd@nbd.name> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240404105217.12478-1-nbd@nbd.name> References: <20240404105217.12478-1-nbd@nbd.name> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_035221_150666_270DFE22 X-CRM114-Status: UNSURE ( 7.42 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Fixes a segmentation fault on sta disconnect Signed-off-by: Felix Fietkau --- src/ap/ndisc_snoop.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ap/ndisc_snoop.c b/src/ap/ndisc_snoop.c index 788c12fdc1cf..bc1eb6251ac0 100644 --- a/src/ap/ndisc_snoop.c +++ b/src/ap/ndisc_snoop.c @@ -61,6 +61,7 @@ void sta_ip6addr_del(struct hos [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Fixes a segmentation fault on sta disconnect Signed-off-by: Felix Fietkau --- src/ap/ndisc_snoop.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ap/ndisc_snoop.c b/src/ap/ndisc_snoop.c index 788c12fdc1cf..bc1eb6251ac0 100644 --- a/src/ap/ndisc_snoop.c +++ b/src/ap/ndisc_snoop.c @@ -61,6 +61,7 @@ void sta_ip6addr_del(struct hostapd_data *hapd, struct sta_info *sta) dl_list_for_each_safe(ip6addr, prev, &sta->ip6addr, struct ip6addr, list) { hostapd_drv_br_delete_ip_neigh(hapd, 6, (u8 *) &ip6addr->addr); + dl_list_del(&ip6addr->list); os_free(ip6addr); } }