diff mbox series

hostap: RNR Bssid is empty

Message ID 20220526071322.4433-1-shay.bar@celeno.com
State Accepted
Headers show
Series hostap: RNR Bssid is empty | expand

Commit Message

Shay Bar May 26, 2022, 7:13 a.m. UTC 
bss->conf->bssid may be kept unset and will cause an empty BSSID field in RNR.
Fix is to use own_addr instead.

Signed-off-by: Shay Bar <shay.bar@celeno.com>
Signed-off-by: moran.daori <moran.daori@celeno.com>
---
 src/ap/ieee802_11.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jouni Malinen Sept. 16, 2022, 7:19 p.m. UTC | #1 
On Thu, May 26, 2022 at 10:13:22AM +0300, Shay Bar wrote:
> bss->conf->bssid may be kept unset and will cause an empty BSSID field in RNR.
> Fix is to use own_addr instead.

Thanks, applied.
diff mbox series

Patch

diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c
index aa26ad4ef..db22b1562 100644
--- a/src/ap/ieee802_11.c
+++ b/src/ap/ieee802_11.c
@@ -7450,7 +7450,7 @@  static u8 * hostapd_eid_rnr_iface(struct hostapd_data *hapd,
 				break;
 
 			*eid++ = RNR_NEIGHBOR_AP_OFFSET_UNKNOWN;
-			os_memcpy(eid, bss->conf->bssid, ETH_ALEN);
+			os_memcpy(eid, bss->own_addr, ETH_ALEN);
 			eid += ETH_ALEN;
 			os_memcpy(eid, &bss->conf->ssid.short_ssid, 4);
 			eid += 4;