| Message ID | 20220411142201.2770618-4-ilan.peer@intel.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v4,1/4] nl80211: set NL80211_SCAN_FLAG_COLOCATED_6GHZ in scan | expand |
On Mon, Apr 11, 2022 at 05:22:01PM +0300, Ilan Peer wrote: > Passively scan 6GHz channels during P2P find full scan as > P2P GOs are not expected to be published in RNR or other > APs on the 2GHz and 5GHz bands. Is this really suggesting all 6 GHz channels to be scanned passively? Wouldn't that take very long time? > diff --git a/wpa_supplicant/p2p_supplicant.c b/wpa_supplicant/p2p_supplicant.c > @@ -444,8 +444,16 @@ static int wpas_p2p_scan(void *ctx, enum p2p_scan_type type, int freq, > - if (!wpa_s->conf->p2p_6ghz_disable) > + if (!wpa_s->conf->p2p_6ghz_disable) { > params->p2p_include_6ghz = include_6ghz; > + > + /* > + * passively scan non PSC channels without relying on collocated > + * logic > + */ > + params->non_coloc_6ghz = include_6ghz; > + } Why would anyone run a P2P group on a non-PSC channel in the 6 GHz band?
Hi, > -----Original Message----- > From: Jouni Malinen <j@w1.fi> > Sent: Monday, April 18, 2022 18:22 > To: Peer, Ilan <ilan.peer@intel.com> > Cc: hostap@lists.infradead.org > Subject: Re: [PATCH v4 4/4] P2P: Do not use collocated scan logic when > scanning 6GHz > > On Mon, Apr 11, 2022 at 05:22:01PM +0300, Ilan Peer wrote: > > Passively scan 6GHz channels during P2P find full scan as P2P GOs are > > not expected to be published in RNR or other APs on the 2GHz and 5GHz > > bands. > > Is this really suggesting all 6 GHz channels to be scanned passively? > Wouldn't that take very long time? > Yes. It would indeed take long time. I believe that regardless of this patch set, this is what is happening today. > > diff --git a/wpa_supplicant/p2p_supplicant.c > > b/wpa_supplicant/p2p_supplicant.c @@ -444,8 +444,16 @@ static int > wpas_p2p_scan(void *ctx, enum p2p_scan_type type, int freq, > > - if (!wpa_s->conf->p2p_6ghz_disable) > > + if (!wpa_s->conf->p2p_6ghz_disable) { > > params->p2p_include_6ghz = include_6ghz; > > + > > + /* > > + * passively scan non PSC channels without relying on > collocated > > + * logic > > + */ > > + params->non_coloc_6ghz = include_6ghz; > > + } > > Why would anyone run a P2P group on a non-PSC channel in the 6 GHz band? > It is not disallowed (the entire P2P operation on 6GHz is not fully defined yet). Would you prefer a patch that instead limits the scanned channels to only include PSC channels? Regards, Ilan.
diff --git a/wpa_supplicant/p2p_supplicant.c b/wpa_supplicant/p2p_supplicant.c index 80ef2a9e4d..e92b7ae35a 100644 --- a/wpa_supplicant/p2p_supplicant.c +++ b/wpa_supplicant/p2p_supplicant.c @@ -444,8 +444,16 @@ static int wpas_p2p_scan(void *ctx, enum p2p_scan_type type, int freq, num_req_dev_types, req_dev_types); if (wps_ie == NULL) goto fail; - if (!wpa_s->conf->p2p_6ghz_disable) + if (!wpa_s->conf->p2p_6ghz_disable) { params->p2p_include_6ghz = include_6ghz; + + /* + * passively scan non PSC channels without relying on collocated + * logic + */ + params->non_coloc_6ghz = include_6ghz; + } + switch (type) { case P2P_SCAN_SOCIAL: params->freqs = os_calloc(ARRAY_SIZE(social_channels_freq) + 1,
Passively scan 6GHz channels during P2P find full scan as P2P GOs are not expected to be published in RNR or other APs on the 2GHz and 5GHz bands. Signed-off-by: Ilan Peer <ilan.peer@intel.com> --- wpa_supplicant/p2p_supplicant.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)