Message ID | 20220401231011.71855-1-masashi.honma@gmail.com |
---|---|
State | Superseded |
Headers | show
Return-Path: <hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=H4t1XAc9; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=DPAZ7E/X; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KVbXl1DRyz9sFk for <incoming@patchwork.ozlabs.org>; Sat, 2 Apr 2022 10:12:04 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=B2uX6c//Q2XetF1vN8oJJoJzIFWIdaZZZWTbs37Hq5M=; b=H4t1XAc95SxKWe t0PlfZZihFBQLmWM9CkhxlxKRNJdhw3kfn01C7zQN6+v/fVZ0IeVf9eiJzowsdJZtOn3Tt+una/D3 Jhrr10pMUVYmWDoc3DZYnAqifsLHP7cVueunxQ3zIPSEs41J5lURq31BoEKQVo4xcb4CE21qLqQaO gugfXWuhe8BltELL2eJMe2ZNi79dH7YB2IWFNjmB1+DiD8X33A6DG5YwpEioU7QGu4yH4YfjssxLf xysLaGB2JYoW3beVJW+4MRK2PvzUvrHKtuu2rqbRG71knk7NZL4cXKCJzLcpMhDC//xw5/drLUSLX PVGdzChQc3raS7nEwf/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naQPd-007Wg6-Ph; Fri, 01 Apr 2022 23:10:37 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1naQPa-007Wfo-Ge for hostap@lists.infradead.org; Fri, 01 Apr 2022 23:10:35 +0000 Received: by mail-pl1-x62a.google.com with SMTP id i11so3701594plr.1 for <hostap@lists.infradead.org>; Fri, 01 Apr 2022 16:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2p1r49MA5zBTWdHZV0sR48B0QP0gbddEVZ/8pLYVg+U=; b=DPAZ7E/X0aE5NpG1Q7O/yhfUZiqeJJ3DEW43PjEPYCtCbb2TAYzOHIGsKSpH4Zv8uM GJduvRHay0lOuXl4rtg5iYVLRMwuVt/i4HvmhzDEvddwYXM5q+dFVl5glO8f6cB1XAlv /qtH8FYzVAvgDk+0NpEP+CmPiUD8j4pVXM33WSanVV3cPqbFakT0ePiz2HgFQ6V7lErC WerUkREmXEB1F4wNml1CuYoZagTOrrIewNPNtq7UC+MAdbwUgD5srsejlG7ADTfx+udq LbcV2iZsQgQIFkmqYqCqungoMePP4E8Q/BglnubmT9J1eyfr0pID5bNysgFVIwvspQtN Jo2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2p1r49MA5zBTWdHZV0sR48B0QP0gbddEVZ/8pLYVg+U=; b=E3PoFZyzpobfFRbIaopx1adVomUOCak+0VkFpEEp/AI71zGb3C4HknDWsnGURACo/A kMa7oi2UqtcWzh5Cvb18UD0EytGOcslD+uZQO0+iIibOh0GbT3kO6EjuAt5JiUTMKD4s jmMPfhPDPhQ/P2OaCzL5NVA4THnHiY5Q5OHM+0Kkyp3Zq6UlQkwIUpqY+6HZ0YYJmGy6 L/+8TxcEULottqMQo5nixa9UdEF1VVj+ywO1Iajq8r8dJt8/apP8CLZ+En3dEnxQAuKc ysrzvrvlW/UpIohE/6+8aVKr14kxSdpGaL0ZcgDsxwmTB2+x7CKGqI3I6rWFjYzt1Akw DUeg== X-Gm-Message-State: AOAM530US2zWJSYtDc1B/KLfyn1fjvQ3saLq0Pyx+9ztv9gnbNGGDk/E yD2khDgWdANWSAKENQ8L6SiVa499JyOnnA== X-Google-Smtp-Source: ABdhPJw5d94yTIg2cE70ZWly0Ev7BR0wQBgyycQ2NFvmNBu8EDLQ0vRst0XMfq7VXY3zVqIK6D0eSQ== X-Received: by 2002:a17:90b:2248:b0:1c9:87d5:11eb with SMTP id hk8-20020a17090b224800b001c987d511ebmr14039766pjb.114.1648854631175; Fri, 01 Apr 2022 16:10:31 -0700 (PDT) Received: from iiyama2004.flets-east.jp ([2409:11:53c0:1f00:1b1d:d372:e97e:923a]) by smtp.gmail.com with ESMTPSA id x39-20020a056a0018a700b004fa7e6ceafesm4337047pfh.169.2022.04.01.16.10.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Apr 2022 16:10:30 -0700 (PDT) From: Masashi Honma <masashi.honma@gmail.com> To: hostap@lists.infradead.org Cc: Masashi Honma <masashi.honma@gmail.com>, Alexander Clouter <alex+hostapd@coremem.com> Subject: [PATCH] Fix SIGSEGV of eapol_test Date: Sat, 2 Apr 2022 08:10:11 +0900 Message-Id: <20220401231011.71855-1-masashi.honma@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220401_161034_611569_C804C9D7 X-CRM114-Status: UNSURE ( 8.53 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Running eapol_test to FreeRADIUS 3.0.25 causes trailing SIGSEGV. WPA_TRACE: eloop SIGSEGV - START [1]: ./eapol_test(+0x67de6) [0x55b84fa4ade6] eloop_sigsegv_handler() ../src/utils/eloop.c:123 [2]: /lib/x86_64-linux-gnu/libc.so.6(+0x430c0) [0x7fec94ad20c0] [3]: ./ea [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:62a listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [masashi.honma[at]gmail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <hostap.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/hostap>, <mailto:hostap-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/hostap/> List-Post: <mailto:hostap@lists.infradead.org> List-Help: <mailto:hostap-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/hostap>, <mailto:hostap-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Hostap" <hostap-bounces@lists.infradead.org> Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
Fix SIGSEGV of eapol_test
|
expand
|
diff --git a/src/common/dpp_tcp.c b/src/common/dpp_tcp.c index a6cca9a13..c83fb2da4 100644 --- a/src/common/dpp_tcp.c +++ b/src/common/dpp_tcp.c @@ -2243,6 +2243,9 @@ bool dpp_tcp_conn_status_requested(struct dpp_global *dpp) { struct dpp_connection *conn; + if (!dpp) + return false; + dl_list_for_each(conn, &dpp->tcp_init, struct dpp_connection, list) { if (conn->auth && conn->auth->conn_status_requested) return true;
Running eapol_test to FreeRADIUS 3.0.25 causes trailing SIGSEGV. WPA_TRACE: eloop SIGSEGV - START [1]: ./eapol_test(+0x67de6) [0x55b84fa4ade6] eloop_sigsegv_handler() ../src/utils/eloop.c:123 [2]: /lib/x86_64-linux-gnu/libc.so.6(+0x430c0) [0x7fec94ad20c0] [3]: ./eapol_test(dpp_tcp_conn_status_requested+0x4) [0x55b84fa7e674] dpp_tcp_conn_status_requested() ../src/common/dpp_tcp.c:2246 [4]: ./eapol_test(wpas_dpp_connected+0x3c) [0x55b84fa816dc] wpas_dpp_connected() dpp_supplicant.c:437 [5]: ./eapol_test(wpa_supplicant_set_state+0x48d) [0x55b84fc12c9d] wpa_supplicant_set_state() wpa_supplicant.c:1067 [6]: ./eapol_test(eapol_sm_step+0x4b4) [0x55b84fb3b994] sm_SUPP_PAE_Step() ../src/eapol_supp/eapol_supp_sm.c:419 eapol_sm_step() ../src/eapol_supp/eapol_supp_sm.c:989 [7]: ./eapol_test(eapol_sm_rx_eapol+0x190) [0x55b84fb3c060] eapol_sm_rx_eapol() ../src/eapol_supp/eapol_supp_sm.c:1293 [8]: ./eapol_test(+0x24760f) [0x55b84fc2a60f] ieee802_1x_decapsulate_radius() eapol_test.c:834 ieee802_1x_receive_auth() eapol_test.c:945 [9]: ./eapol_test(+0x248d46) [0x55b84fc2bd46] radius_client_receive() ../src/radius/radius_client.c:937 [10]: ./eapol_test(+0x68323) [0x55b84fa4b323] eloop_sock_table_dispatch() ../src/utils/eloop.c:606 [11]: ./eapol_test(eloop_run+0x251) [0x55b84fa4be51] eloop_sock_table_dispatch() ../src/utils/eloop.c:597 eloop_run() ../src/utils/eloop.c:1234 [12]: ./eapol_test(main+0x8cf) [0x55b84fa30d6f] main() eapol_test.c:1517 WPA_TRACE: eloop SIGSEGV - END Aborted (core dumped) Reported-by: Alexander Clouter <alex+hostapd@coremem.com> Signed-off-by: Masashi Honma <masashi.honma@gmail.com> --- src/common/dpp_tcp.c | 3 +++ 1 file changed, 3 insertions(+)