| Message ID | 20220302222634.22185-3-quic_alokad@quicinc.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | hostapd: MBSSID and EMA support | expand |
On Wed, Mar 02, 2022 at 02:26:23PM -0800, Aloka Dixit wrote: > Retrieve driver capabilities for maximum number of interfaces for > MBSSID and maximum allowed profile periodicity for enhanced MBSSID > advertisements. > hostapd/main.c | 3 +++ > src/ap/hostapd.h | 5 +++++ > src/drivers/driver.h | 5 +++++ > 3 files changed, 13 insertions(+) This looks a bit strange without the driver_nl80211_capa.c changes. Without those, there is not really any functionality here.. Furthermore, the commit message for patch 13/13 where that functionality is added is just talking about sending the parameters to the kernel. It would seem better to move those driver_nl80211_capa.c changes from 13/13 to this 2/13.
diff --git a/hostapd/main.c b/hostapd/main.c index c9ec38d19f88..19db9bc446e3 100644 --- a/hostapd/main.c +++ b/hostapd/main.c @@ -240,6 +240,9 @@ static int hostapd_driver_init(struct hostapd_iface *iface) wpa_printf(MSG_ERROR, "set_wowlan failed"); } os_free(triggs); + + iface->mbssid_max_interfaces = capa.mbssid_max_interfaces; + iface->ema_max_periodicity = capa.ema_max_periodicity; } return 0; diff --git a/src/ap/hostapd.h b/src/ap/hostapd.h index f3ca7529ac96..def0971cc11f 100644 --- a/src/ap/hostapd.h +++ b/src/ap/hostapd.h @@ -596,6 +596,11 @@ struct hostapd_iface { /* Previous WMM element information */ struct hostapd_wmm_ac_params prev_wmm[WMM_AC_NUM]; + /* Maximum number of interfaces supported for MBSSID advertisements */ + u8 mbssid_max_interfaces; + /* Maximum profile periodicity for enhanced MBSSID advertisements */ + u8 ema_max_periodicity; + int (*enable_iface_cb)(struct hostapd_iface *iface); int (*disable_iface_cb)(struct hostapd_iface *iface); }; diff --git a/src/drivers/driver.h b/src/drivers/driver.h index ebc550fbe630..cf0f2180e704 100644 --- a/src/drivers/driver.h +++ b/src/drivers/driver.h @@ -2141,6 +2141,11 @@ struct wpa_driver_capa { /* Maximum number of supported CSA counters */ u16 max_csa_counters; + + /* Maximum number of interfaces supported for MBSSID advertisements */ + u8 mbssid_max_interfaces; + /* Maximum profile periodicity for enhanced MBSSID advertisements */ + u8 ema_max_periodicity; };
Retrieve driver capabilities for maximum number of interfaces for MBSSID and maximum allowed profile periodicity for enhanced MBSSID advertisements. Signed-off-by: Aloka Dixit <quic_alokad@quicinc.com> --- hostapd/main.c | 3 +++ src/ap/hostapd.h | 5 +++++ src/drivers/driver.h | 5 +++++ 3 files changed, 13 insertions(+)