From patchwork Thu Jul 16 00:17:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Wang X-Patchwork-Id: 1329873 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1231::1; helo=merlin.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=merlin.20170209 header.b=ebx2fnuq; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=l38DCMI+; dkim-atps=neutral Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4B6ZcV51Wcz9sTF for ; Thu, 16 Jul 2020 10:19:06 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0MQZ6EAWpKz4bwBQYMYzeCuWbNbbOGer+0o6GdwCNqc=; b=ebx2fnuqP47sM8h0LyLJ8YK6V 2xKip5Wa3Y4EA5PUp22aExnuG62CF3EG1gEoOX9l01+lGE/1UxcKSFnvdaLX9Ctyfr0SWXOQMAbB7 +MtHzRDFaxkqf3Ux+Jikfxgyi+aoy73e2GkmM4xRZLEKQppTpBCIrPdaC9TDdphQEUQFfZyiiEs/y SJ9ye51ubOqbSYOZit+FhWY3oEwEL5gq27GQZSFFmLJiQbsu12yZprapdcMx0q6MQ0urQzfonGwtO 5kQEMqGozYXotVa9Sp38FPNiUNgCmWbL0+65vMqLcmJ8F9WMRhJzA/n5SDsgtyn6q190vAeRk3rXk +NV52NObQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvrbM-0001Lo-8z; Thu, 16 Jul 2020 00:18:16 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvrbJ-0001Km-2j for hostap@lists.infradead.org; Thu, 16 Jul 2020 00:18:13 +0000 Received: by mail-pj1-x102c.google.com with SMTP id b92so3793757pjc.4 for ; Wed, 15 Jul 2020 17:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kt5nwsZFFbJkU4jI3y0yQdtOQj7+h/4sUyjrMhY3538=; b=l38DCMI+3yLgvkUyKxepwv+BI6dTB4RhUzYJxoCaL1nezCzuNkRymoj5yDryOrh1XN W/s2WsLXvXgTndQs0mD9My+F5nY+kkIq4y5RyFIISpgrFZEgw6n7Bryk8C8YT1n/D2ET upHWG7RB8T83cYO9sqfvKjg6t3tV6oWiVVyzw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kt5nwsZFFbJkU4jI3y0yQdtOQj7+h/4sUyjrMhY3538=; b=U8i31jV0FUin0R8CRd2oZy0ObsDsZ2c3w8baUkPDArwRlt428f0vbZtzTY37L7KQf1 X9rnJqqeUz4mBBpcBzxaHszKFWMnjUYMGZ+Y2La9ymI+O8HUdEbmWLYvNLl6CHgbTl0l JPgYT1hD4Fq2pyrdQ5Xe9VuxGu+kYY2OgzGDdVy6Urw2wjbPSHXb1cCc5ok9MTZ/q6F/ zyuQINY639UTzu8PX+paNi7rK7IfwcCy+Z2znSvFLIoajuFzP+1Ot7GTg+0jpUT3BoAe oumldCQatkYVVJRqmWxCohuz1qTO+h014jpcDWkVtscu5uUrId+NNP2A2LwqqNMS4OsQ f8xw== X-Gm-Message-State: AOAM530NgicmvB+sqZ/x1gxQuWtYiYHPXjclZ8pJNMBSdU4U0dON1fc8 /C34LRAqvIc4O+46EGCTVGAh+g== X-Google-Smtp-Source: ABdhPJy0/77yLomWZ4HBbdUqKXDCSmz+xN12boaJABTsZUHvcBRbMYv/FWf8L6U/X4M7MimBYwlIMA== X-Received: by 2002:a17:902:d203:: with SMTP id t3mr1636699ply.168.1594858690631; Wed, 15 Jul 2020 17:18:10 -0700 (PDT) Received: from localhost ([2620:15c:202:201:cad3:ffff:feb9:25d2]) by smtp.gmail.com with ESMTPSA id q24sm3111125pfg.34.2020.07.15.17.18.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jul 2020 17:18:10 -0700 (PDT) From: Matthew Wang To: j@w1.fi Subject: [PATCH V2 4/4] allow empty string in dbus network properties Date: Wed, 15 Jul 2020 17:17:43 -0700 Message-Id: <20200716001743.4085346-5-matthewmwang@chromium.org> X-Mailer: git-send-email 2.27.0.389.gc38d7665816-goog In-Reply-To: <20200716001743.4085346-1-matthewmwang@chromium.org> References: <20200716001743.4085346-1-matthewmwang@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_201813_242143_EA8EA7D8 X-CRM114-Status: GOOD ( 10.74 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:102c listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hostap@lists.infradead.org, Matthew Wang Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Signed-off-by: Matthew Wang --- wpa_supplicant/dbus/dbus_new_handlers.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/wpa_supplicant/dbus/dbus_new_handlers.c b/wpa_supplicant/dbus/dbus_new_handlers.c index c5225ca99..a7ce20f2d 100644 --- a/wpa_supplicant/dbus/dbus_new_handlers.c +++ b/wpa_supplicant/dbus/dbus_new_handlers.c @@ -229,8 +229,6 @@ dbus_bool_t set_network_properties(struct wpa_supplicant *wpa_s, } else if (entry.type == DBUS_TYPE_STRING) { if (should_quote_opt(entry.key)) { size = os_strlen(entry.str_value); - if (size == 0) - goto error; size += 3; value = os_zalloc(size);