From patchwork Wed Jul 1 02:47:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Wang X-Patchwork-Id: 1320217 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1231::1; helo=merlin.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=merlin.20170209 header.b=s4OMCc7Q; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=E74cAHe6; dkim-atps=neutral Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49xQf74pwMz9sPF for ; Wed, 1 Jul 2020 12:48:47 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=yVDFCD4rXVsAiAbutm7sEn4+n0qtnznoHn7R8tLaleM=; b=s4OMCc7QC6KbeOVx/iS2ZjTkcD Qv6sYtCacS3HMMHLLFJ2GMwEfXGhQB5YA96H1ibuIP28iDsR5cIAdTy1PoBUshrRbfNwHADkR33XR qBQHfFml1zgibZ8jqUUtsL7hBjXSoL5cMfokueKD6ykW+ejRq/ENQEC8i7PYdrdLt7+euVRFGT1Du CIJ1vzhejLWspkqWVOdvI4aO4Bg8Qtc73auZ5tz4OQUEFhim3oEqH7SmkzRdSB4utyNxBXatZ1GkW yBcC0EfAbA66MUzi5busHOyHqzS9NyB3R6jolwKS8J/gJi0VjVRXSVIf/HjzATFczVam2T4SABv7e 5ffeJvRg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqSmd-0004da-Pk; Wed, 01 Jul 2020 02:47:35 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqSma-0004d8-Ae for hostap@lists.infradead.org; Wed, 01 Jul 2020 02:47:33 +0000 Received: by mail-pl1-x643.google.com with SMTP id p1so35264pls.4 for ; Tue, 30 Jun 2020 19:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6mFs+dZkBh+XcgYeP647EEdye/n7YvF8UKDKIbBSQGo=; b=E74cAHe6Wbv+W1vRTJEAnu4mYQrL7t2ATn0WWbbgqwHK9oCspzLYQMtL8GkhRH0afy PgeoInn+U2yOhndZOrLG/LqMsZYrvdNnJaYD1NsrpnowajgpAsvtqQ7kHEec972/aMA+ UDHuZzeqHApfL8neoSAwiZWDjVvSl8As5DEtQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6mFs+dZkBh+XcgYeP647EEdye/n7YvF8UKDKIbBSQGo=; b=Beq2GMT0Q3xLjLLlBD9bZ0+CjSJ8FGlQvmDzR/tYYLn2jh1X45c8nB8JuZ0UY0J3yA v/0jQwDliqCHLmzuOR0rVHCg1+lsDN10FU8J3nwVr9Fmg8xaeFu9iWBUdclZfpuu7GRv GCydoiF5q8gPOA++HEL1H0RN8AieKOgsDN3Jnutyy4im5KL4CaQ7nGJ1v827jwwudAEe l1kgWbHKwzxZUc3nThywy9b4VLbXm4z8fvwq8WWxkidYvEKH3mZSZTt0w1oJrrelFPRF UQzORV8e6pgrN+peFpq41Xtyd8sjt7BzX6tXKfBuQzCYKQkWLFQUC+B8zJscJ9AocpuO 1DEw== X-Gm-Message-State: AOAM532fiH+Bo6WjT+3K9CkgjqQBRcxktAh06dIA+VkLEKzf8Z1bu/mQ M+7Aw1qGXzGh9oWwoXgJCtfBnw== X-Google-Smtp-Source: ABdhPJwU7/XhCCu5ZKDbmLEV0UMyEI3WCqJdRmHMBPbiSPpD04qqn79caoF72F/jTIT55EqtL1RSAQ== X-Received: by 2002:a17:90a:ebc7:: with SMTP id cf7mr2670737pjb.207.1593571648661; Tue, 30 Jun 2020 19:47:28 -0700 (PDT) Received: from localhost ([2620:15c:202:201:cad3:ffff:feb9:25d2]) by smtp.gmail.com with ESMTPSA id 83sm3959964pfu.60.2020.06.30.19.47.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2020 19:47:27 -0700 (PDT) From: Matthew Wang To: j@w1.fi Subject: [PATCH] allow empty string in dbus network properties Date: Tue, 30 Jun 2020 19:47:22 -0700 Message-Id: <20200701024722.1516280-1-matthewmwang@chromium.org> X-Mailer: git-send-email 2.27.0.212.ge8ba1cc988-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200630_224732_415706_D0EE4372 X-CRM114-Status: GOOD ( 10.47 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:643 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hostap@lists.infradead.org, Matthew Wang Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Signed-off-by: Matthew Wang --- wpa_supplicant/dbus/dbus_new_handlers.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/wpa_supplicant/dbus/dbus_new_handlers.c b/wpa_supplicant/dbus/dbus_new_handlers.c index d1f9607c6..bc35dc957 100644 --- a/wpa_supplicant/dbus/dbus_new_handlers.c +++ b/wpa_supplicant/dbus/dbus_new_handlers.c @@ -229,8 +229,6 @@ dbus_bool_t set_network_properties(struct wpa_supplicant *wpa_s, } else if (entry.type == DBUS_TYPE_STRING) { if (should_quote_opt(entry.key)) { size = os_strlen(entry.str_value); - if (size == 0) - goto error; size += 3; value = os_zalloc(size);