From patchwork Thu Jun 25 20:22:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 1317605 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1231::1; helo=merlin.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=merlin.20170209 header.b=AFZIRcrA; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=lA/vzeIP; dkim-atps=neutral Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49tbP02pMCz9sPF for ; Fri, 26 Jun 2020 22:12:36 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jAiPmlf7xX4Wesy7B8S+Cdz9OwfTt8WGV4EsSG7ijVc=; b=AFZIRcrAwnhaF3gkwD9nNNigt prgczrcIJVs6HnJT77YiKPwKknoJsmBEgb2ocZORWBFZDwkXZsUhe2BBj3zIQIEe0KcZz1p0E8rhy lULvg1NE9yCMpztchRBR9MJjou8TP57XrMEyZjUvCPAHoShEqR6/mXJb2fdzv9nkQpkh4W0kCr7UD T4cu8dHwwAFGPgcSJTe9Ni+ED+USaX2ww+WeCjmDDbSTicz/IzmTT7vUSrKOYwZP7Pf5flpHkvt6m 84FP8i+1U2rrSBIU+85n02GMaJop7IrCD0L7HFeKkq7lCf2RFv1P0sTKxYEOMIzT1y7kKN/kq2kEn bNUol6mNA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jonCa-0006bZ-Mn; Fri, 26 Jun 2020 12:11:28 +0000 Received: from mail-il1-x142.google.com ([2607:f8b0:4864:20::142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joml5-0001hB-RH for hostap@lists.infradead.org; Fri, 26 Jun 2020 11:43:06 +0000 Received: by mail-il1-x142.google.com with SMTP id r12so939079ilh.4 for ; Fri, 26 Jun 2020 04:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GbIqFKHTnTfNp3YMYhuEM9DLjmOLrbiYvhkLM7HJK1A=; b=lA/vzeIPwqco5BPKRIoZhE5f/rj2XTnhHa9Syv+TNeOk3rZMkkcgbk3BiJPqcWIEtu sbU/pI26rhbyRN0rG5NmTaS8rJ1i3emH/e2XRaBUo4WCc5pvah2Dln3d3H3/yCCBofH+ hRDh0Kd6xvnXhz0Tz5jVCkJalgImdF04zLb38= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GbIqFKHTnTfNp3YMYhuEM9DLjmOLrbiYvhkLM7HJK1A=; b=I6Z3PMMNiB6pTNrjjVMLaMQuukIpiufHrjyB6NOxFn6m1izv3etlXPReNszlHnbLgO usHd1y1GdV3vJV2vLgDvl/KtGOqj3sVL5MiRMwM4elE0pciXHbPubyby3c9rHzB3CxER 3qEo0BTVwFE9CB7HzCWO3NEoul7D0wnWvjiec7xIz0ua6pC9/TXKJZRy1rgofUtLJpFX nNEfz+QPokqfni3dKTSMmTgJBt3yPpjot240ot1L6qPrjVOYEAiLBgxS/Lz0nDnxY7s6 JOj7AFDBqRGJfjsXRQyCU/q6DxYC/Jahird4wo13IeYEBKGX/3SVD9wR80a370ZGFR+b HVxA== X-Gm-Message-State: AOAM530xK8zRSQ1jg9SxuqbLP9Jee4TMQHN4DN7Tqa2l+Pk1yUf8B5pO eztODjKdAiZH+xV7wqpGwB6lZf6v/Ys= X-Google-Smtp-Source: ABdhPJxm763/48PCbCJnjC3FvTFiG2G5vYhbiNNr456vGhksUiLUJ0FxwezAsOZZF1jOmFotCAyCsQ== X-Received: by 2002:a63:5a54:: with SMTP id k20mr27300425pgm.226.1593116535489; Thu, 25 Jun 2020 13:22:15 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:1:534:b7c0:a63c:460c]) by smtp.gmail.com with ESMTPSA id w18sm24043489pfq.121.2020.06.25.13.22.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 13:22:14 -0700 (PDT) From: Brian Norris To: hostap@lists.infradead.org Subject: [PATCH 2/2] tests: run-tests: don't use sudo if already root Date: Thu, 25 Jun 2020 13:22:02 -0700 Message-Id: <20200625202202.93564-2-briannorris@chromium.org> X-Mailer: git-send-email 2.27.0.212.ge8ba1cc988-goog In-Reply-To: <20200625202202.93564-1-briannorris@chromium.org> References: <20200625202202.93564-1-briannorris@chromium.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:142 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Brian Norris Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Among other things, sudo can disrupt environment variables that a caller provides. Signed-off-by: Brian Norris --- tests/hwsim/run-all.sh | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/hwsim/run-all.sh b/tests/hwsim/run-all.sh index 495c9fa744b8..ee48cd0581c6 100755 --- a/tests/hwsim/run-all.sh +++ b/tests/hwsim/run-all.sh @@ -122,7 +122,13 @@ if ! ./start.sh $VM $VALGRIND $TRACE channels=$NUM_CH; then exit 1 fi -sudo ./run-tests.py -D --logdir "$LOGDIR" $TRACE_ARGS -q $DB $RUN_TEST_ARGS || errors=1 +# Only use sudo if not already root. +if [ "$(id -u)" != 0 ]; then + SUDO=sudo +else + SUDO= +fi +${SUDO} ./run-tests.py -D --logdir "$LOGDIR" $TRACE_ARGS -q $DB $RUN_TEST_ARGS || errors=1 ./stop.sh