diff mbox series

[2/5] wpa_supplicant: Bump up logging level for blacklist decisions

Message ID 20191206222748.153534-2-matthewmwang@chromium.org
State Changes Requested
Headers show
Series [1/5] wpa_supplicant: Bump up logging level for roaming decisions | expand

Commit Message

Matthew Wang Dec. 6, 2019, 10:27 p.m. UTC 
From: Kirtika Ruchandani <kirtika@chromium.org>

Chrome OS relies on its connection manager, shill, to bump up the
logging level in wpa_supplicant during 'interesting' times via its
WiFi::SetConnectionDebugging method. The method sets wpa_supplicant
debug level to 'info' (quieter) or 'debug' (verbose).
It's not clear SetConnectionDebugging is being called on execution
paths of interest - in particular, APs we are connected to at one
instant show up as blacklisted in the scan after an unexpected
disconnect, like so: (<> implies redacted/placeholder)

wlan0: New scan results available (own=1 ext=0)
wlan0: Radio work 'scan'@<> done in <> seconds
wlan0: Selecting BSS from priority group <>
// This SSID was one we were connected to before, and there was
// no mention of blacklisting it in the log lines prior to this.
wlan0: 0: <> ssid='<>' wpa_ie_len=0 rsn_ie_len=<> caps=<> level=<> freq=<>  wps
wlan0:    skip - blacklisted (count=2 limit=0)
wlan0: 1: <> ssid='<>' wpa_ie_len=0 rsn_ie_len=<> caps=<> level=<> freq=<>  wps

Ensure that we always print blacklist adding/clearing decisions - its
only 3 lines anyways.

Signed-off-by: Kirtika Ruchandani <kirtika@chromium.org>
---
 wpa_supplicant/blacklist.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/wpa_supplicant/blacklist.c b/wpa_supplicant/blacklist.c
index e53dc38b3..da9259ce0 100644
--- a/wpa_supplicant/blacklist.c
+++ b/wpa_supplicant/blacklist.c
@@ -63,7 +63,7 @@  int wpa_blacklist_add(struct wpa_supplicant *wpa_s, const u8 *bssid)
 	e = wpa_blacklist_get(wpa_s, bssid);
 	if (e) {
 		e->count++;
-		wpa_printf(MSG_DEBUG, "BSSID " MACSTR " blacklist count "
+		wpa_printf(MSG_INFO, "BSSID " MACSTR " blacklist count "
 			   "incremented to %d",
 			   MAC2STR(bssid), e->count);
 		return e->count;
@@ -104,7 +104,7 @@  int wpa_blacklist_del(struct wpa_supplicant *wpa_s, const u8 *bssid)
 			} else {
 				prev->next = e->next;
 			}
-			wpa_printf(MSG_DEBUG, "Removed BSSID " MACSTR " from "
+			wpa_printf(MSG_INFO, "Removed BSSID " MACSTR " from "
 				   "blacklist", MAC2STR(bssid));
 			os_free(e);
 			return 0;
@@ -132,7 +132,7 @@  void wpa_blacklist_clear(struct wpa_supplicant *wpa_s)
 			max_count = e->count;
 		prev = e;
 		e = e->next;
-		wpa_printf(MSG_DEBUG, "Removed BSSID " MACSTR " from "
+		wpa_printf(MSG_INFO, "Removed BSSID " MACSTR " from "
 			   "blacklist (clear)", MAC2STR(prev->bssid));
 		os_free(prev);
 	}