| Message ID | 20190326114132.9343-1-john@phrozen.org |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | HE: set field to 1023 if no he_rts_threshold is set in the configuration | expand |
On 26/03/2019 12:41, John Crispin wrote: > "9.4.2.243 HE Operation element" states that when no RTS threshold is > set, the field should be set to 1023. This patch extends the if clause > to do just that. > > Signed-off-by: John Crispin <john@phrozen.org> > --- > src/ap/ieee802_11_he.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/ap/ieee802_11_he.c b/src/ap/ieee802_11_he.c > index 33f1ed14e..e940312cf 100644 > --- a/src/ap/ieee802_11_he.c > +++ b/src/ap/ieee802_11_he.c > @@ -76,6 +76,9 @@ u8 * hostapd_eid_he_operation(struct hostapd_data *hapd, u8 *eid) > oper->he_oper_params |= > (hapd->iface->conf->he_op.he_rts_threshold << > HE_OPERATION_RTS_THRESHOLD_OFFSET); > + else > + oper->he_oper_params |= > + HE_OPERATION_RTS_THRESHOLD_MASK; > > if (hapd->iface->conf->he_op.he_bss_color) > oper->he_oper_params |= Hi, please dont apply this, its better to set he_rts_threshold to 1023 inside config_file.c if the parameter is not passed inside the conf file, as 0 is actually a valid value for the element. I'll send a V2 shortly. John
diff --git a/src/ap/ieee802_11_he.c b/src/ap/ieee802_11_he.c index 33f1ed14e..e940312cf 100644 --- a/src/ap/ieee802_11_he.c +++ b/src/ap/ieee802_11_he.c @@ -76,6 +76,9 @@ u8 * hostapd_eid_he_operation(struct hostapd_data *hapd, u8 *eid) oper->he_oper_params |= (hapd->iface->conf->he_op.he_rts_threshold << HE_OPERATION_RTS_THRESHOLD_OFFSET); + else + oper->he_oper_params |= + HE_OPERATION_RTS_THRESHOLD_MASK; if (hapd->iface->conf->he_op.he_bss_color) oper->he_oper_params |=
"9.4.2.243 HE Operation element" states that when no RTS threshold is set, the field should be set to 1023. This patch extends the if clause to do just that. Signed-off-by: John Crispin <john@phrozen.org> --- src/ap/ieee802_11_he.c | 3 +++ 1 file changed, 3 insertions(+)