From patchwork Fri Oct 26 13:50:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 989593 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sipsolutions.net Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UFomxtBM"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=infradead.org header.i=@infradead.org header.b="zsrf9xuK"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42hRCN3Tcsz9sDr for ; Sat, 27 Oct 2018 01:27:12 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=PNg7K0zMQITQ/rddG/+oU5O6ORUu/1FoZ4XjPGUEg1s=; b=UFo mxtBMQFo+k6uKm70YDCsYedkRkvXsVldKkpgLk+8xQOfd0mLA5Fd8yYO13YpwFwK8lmQrTERaW1Ap aN9u2G6Bteasyfgd4oaBUiPN6pjta1L72wp34Fv1WZEUY+fegldWhbftPSCeYFyG/nYAx8wCPtdYO q4UZn77MB+TISUXsowWd4A9KGLOHDYR6AM4DPdIcmm5G8prUWj6GlYMchaEvwMamVkYy7+wSF1qIT KcbecqDYJWMzrNHFZxvXts2oy/m5c0bnO/OLxnUKON5dO95k74TTaD+DGeoqM5zMqq8Tm3suiKkSN bmbFNXO8LorTdIBIZi7mYyG6ZErwEWw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gG343-0007fb-7P; Fri, 26 Oct 2018 14:26:15 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gG33p-0007au-7W for hostap@bombadil.infradead.org; Fri, 26 Oct 2018 14:26:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Y6+1ORxtKPORcib9RYE9UGg6gqJfw0LIHYDWTofIlpE=; b=zsrf9xuKTGbpgruPUOFpEq8vK x3q2hapDs4eJyyovKHI2iaDA/glJbWQxb/LJ7UZgcZMgGuepSMRM9DQ+/hc4UByB3quxzlwfE/k2P Lk+sItp0s0YP0GM8pZHV20gERDYXLSiOMqPJyL4jy6TDXSTZ+jAyyMHl0ftnnGXKplZqSIWDNPeSk qf40rpNH8UQfXDv1k3+maYFwLlHa+/8LBuTnufpAxv1mWtazp61Utnj7fuCgHpr9X5D53oJwBOhd2 6BlMLT+4JRAQYTLXlojmJRpZRPHbYSOf8E7FrJ4BTVqd+XgfT2E98Chf69IU11VxINakoTa4pIPTR C5W1dOLBQ==; Received: from s3.sipsolutions.net ([2a01:4f8:191:4433::2] helo=sipsolutions.net) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gG2Wc-0002Fo-JF for hostap@lists.infradead.org; Fri, 26 Oct 2018 13:51:43 +0000 Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.91) (envelope-from ) id 1gG2WL-00024d-87; Fri, 26 Oct 2018 15:51:25 +0200 From: Johannes Berg To: hostap@lists.infradead.org Subject: [PATCH] driver_nl80211: use correct u8 size for NL80211_ATTR_SMPS_MODE Date: Fri, 26 Oct 2018 15:50:48 +0200 Message-Id: <20181026135048.18002-1-johannes@sipsolutions.net> X-Mailer: git-send-email 2.17.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181026_095142_645699_06F65013 X-CRM114-Status: GOOD ( 13.63 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.2 on merlin.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Johannes Berg MIME-Version: 1.0 Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Johannes Berg Back in December 2017, Jouni fixed the output side since that was causing a kernel message to be printed, but the input side should also be fixed, otherwise it will not work correctly on big-endian platforms. Signed-off-by: Johannes Berg --- src/drivers/driver_nl80211_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/drivers/driver_nl80211_event.c b/src/drivers/driver_nl80211_event.c index 5b8efbc172cb..bac83898db90 100644 --- a/src/drivers/driver_nl80211_event.c +++ b/src/drivers/driver_nl80211_event.c @@ -2271,7 +2271,7 @@ static void nl80211_sta_opmode_change_event(struct wpa_driver_nl80211_data *drv, ed.sta_opmode.addr = nla_data(tb[NL80211_ATTR_MAC]); if (tb[NL80211_ATTR_SMPS_MODE]) { - smps_mode = nla_get_u32(tb[NL80211_ATTR_SMPS_MODE]); + smps_mode = nla_get_u8(tb[NL80211_ATTR_SMPS_MODE]); switch (smps_mode) { case NL80211_SMPS_OFF: ed.sta_opmode.smps_mode = SMPS_OFF;