From patchwork Mon Sep 29 02:07:19 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bob Copeland X-Patchwork-Id: 394249 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from maxx.maxx.shmoo.com (maxx.shmoo.com [205.134.188.171]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id B02B714008C for ; Mon, 29 Sep 2014 12:07:47 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by maxx.maxx.shmoo.com (Postfix) with ESMTP id 096CB9D263; Sun, 28 Sep 2014 22:07:45 -0400 (EDT) X-Virus-Scanned: amavisd-new at maxx.shmoo.com Received: from maxx.maxx.shmoo.com ([127.0.0.1]) by localhost (maxx.shmoo.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N0s5VJdGVY2u; Sun, 28 Sep 2014 22:07:44 -0400 (EDT) Received: from maxx.shmoo.com (localhost [127.0.0.1]) by maxx.maxx.shmoo.com (Postfix) with ESMTP id 005209D28F; Sun, 28 Sep 2014 22:07:40 -0400 (EDT) X-Original-To: mailman-post+hostap@maxx.shmoo.com Delivered-To: mailman-post+hostap@maxx.shmoo.com Received: from localhost (localhost [127.0.0.1]) by maxx.maxx.shmoo.com (Postfix) with ESMTP id D99F69D263 for ; Sun, 28 Sep 2014 22:07:38 -0400 (EDT) X-Virus-Scanned: amavisd-new at maxx.shmoo.com Received: from maxx.maxx.shmoo.com ([127.0.0.1]) by localhost (maxx.shmoo.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x-uGH8eRqmfh for ; Sun, 28 Sep 2014 22:07:33 -0400 (EDT) Received: from mail-ie0-f178.google.com (mail-ie0-f178.google.com [209.85.223.178]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (not verified)) by maxx.maxx.shmoo.com (Postfix) with ESMTPS id B30679D28F for ; Sun, 28 Sep 2014 22:07:33 -0400 (EDT) Received: by mail-ie0-f178.google.com with SMTP id rl12so3328920iec.23 for ; Sun, 28 Sep 2014 19:07:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=maZ1owMMprMblyk4Z3Y3xvVL2YhtGtD+qtBltGGokJU=; b=lYWwAGO8zUMWboku+LIWLbExtE2e0L14CAVPmk9MM3KxgeRhOXB4xCwrURAp9RL+XB U+HPcz40OCkzJS7+8JKgIDqu4bJi4w0NfPy+PbUSlBYVqVvt09FocS+aHhp5l4CvNSJ8 55Gi0cn80dKKYvguKchlrAIAXHCcPDL/ztIXDHg4EOma+zo6jjFBDwsYX18nVE4z3fVr iGuvzA9XaZx2HT7Fm3U7ez4t/sbDvYTCl1h0PHDLQku/z3Jja92b0GTyxvWwdl9gVogu pDtgdKVtl6ChffGDHxdEdf1NL/gZvLRgzSe2ocXNGXuL6ScnzYQGMAQnm48iOiFssh7Z v64A== X-Gm-Message-State: ALoCoQnKehdbxkoHb+5beqgPbqsmq+lURO74dEW78ELgiPVpKcUq6+lQPFOksTfS3tXAC/AyoUQt X-Received: by 10.43.153.137 with SMTP id la9mr7466216icc.42.1411956452681; Sun, 28 Sep 2014 19:07:32 -0700 (PDT) Received: from hash ([2001:470:1d:6db:230:48ff:fe9d:9c89]) by mx.google.com with ESMTPSA id hv4sm8836957igb.19.2014.09.28.19.07.30 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 28 Sep 2014 19:07:31 -0700 (PDT) Received: from bob by hash with local (Exim 4.80) (envelope-from ) id 1XYQMx-000343-HV for hostap@lists.shmoo.com; Sun, 28 Sep 2014 22:07:19 -0400 Date: Sun, 28 Sep 2014 22:07:19 -0400 From: Bob Copeland To: hostap@lists.shmoo.com Subject: Re: [PATCH v2 00/20] mesh support for wpa_supplicant Message-ID: <20140929020719.GA11613@localhost> References: <1409545419-2301-1-git-send-email-me@bobcopeland.com> <20140928184512.GA18873@w1.fi> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140928184512.GA18873@w1.fi> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: hostap@lists.shmoo.com X-Mailman-Version: 2.1.11 Precedence: list List-Id: HostAP Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: hostap-bounces@lists.shmoo.com Errors-To: hostap-bounces@lists.shmoo.com On Sun, Sep 28, 2014 at 09:45:12PM +0300, Jouni Malinen wrote: > On Mon, Sep 01, 2014 at 12:23:19AM -0400, Bob Copeland wrote: > > This is an updated posting of the mesh-for-wpa_supplicant patchset, > > which allows creating an open or secure (SAE) 802.11s mesh. > > It looks like this breaks number of TDLS hwsim test cases (both with and > without CONFIG_MESH=y). This seems to be due to set_key failing for peer > with "No such file or directory", i.e., likely missing a proper STA > entry for the peer. Any idea why? driver_nl80211.c has changes in > sta_add handler, so I'd assume those are related. Hmm, yes, it looks like this restores passing on TDLS cases (but breaks the mesh test cases). I guess mesh MPM should just be setting supp_rates when marking the sta authenticated. > I pushed my temporary work branch ('mesh') into hostap.git to make it > easier to see where I'm with the review and to send any additional > patches on top of that version, if needed. Great, thanks! diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c index 44d07fe..4b0dad0 100644 --- a/src/drivers/driver_nl80211.c +++ b/src/drivers/driver_nl80211.c @@ -7754,11 +7754,12 @@ static int wpa_driver_nl80211_sta_add(void *priv, NLA_PUT_U32(msg, NL80211_ATTR_IFINDEX, if_nametoindex(bss->ifname)); NLA_PUT(msg, NL80211_ATTR_MAC, ETH_ALEN, params->addr); + NLA_PUT(msg, NL80211_ATTR_STA_SUPPORTED_RATES, + params->supp_rates_len, params->supp_rates); + wpa_hexdump(MSG_DEBUG, " * supported rates", + params->supp_rates, params->supp_rates_len); + if (!params->set) { - NLA_PUT(msg, NL80211_ATTR_STA_SUPPORTED_RATES, - params->supp_rates_len, params->supp_rates); - wpa_hexdump(MSG_DEBUG, " * supported rates", - params->supp_rates, params->supp_rates_len); if (params->aid) { wpa_printf(MSG_DEBUG, " * aid=%u", params->aid);