From patchwork Tue Jan 8 00:18:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Siedzik X-Patchwork-Id: 1021537 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=extremenetworks.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AVQPaNF7"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=extremenetworks.com header.i=@extremenetworks.com header.b="hAgWvP4n"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43YQD05vHHz9sD9 for ; Tue, 8 Jan 2019 06:18:40 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=lge4FN4gqRcrGOFtN8G7tcXSJKveplFr+BYK774OkBg=; b=AVQPaNF703ZW02 WD7s4S3BuwjRI8/51qk3Yso7SSecU6DIGZJI/IYmURaZ/hB5z9GwPVgllf/8KAtpcLba8rvH0wSXN EtX4xYDAke1EEzbB9JeLoouSpRHgh+NWJbvNZSIg/OsKo/IQm9fB9RwZ4goZZ4aGVGONHODs8gHcU S+iIPjuj+YNJFh+eEzHovLztrmUIWDGo568/VVB8uU1VhQqpYETz7qEy8vRnYtadfk7UkzTm7wAXt no5EbTod0mNmGIYzQoeS/mqiS8jq9CwFQKNk6xhoWLEJYPauMPuj+C7SAOO3xo8/drnA1z8JP16dC RK6JFm7IKv0Z7EHwPzbw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ggaPu-0002ls-Ii; Mon, 07 Jan 2019 19:18:30 +0000 Received: from us-smtp-delivery-183.mimecast.com ([216.205.24.183]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ggaPp-0002lD-5z for hostap@lists.infradead.org; Mon, 07 Jan 2019 19:18:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=extremenetworks.com; s=mimecast20180820; t=1546888701; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=7dNSZRcBQqvostXxn2+x/oiTI6tZNYV2JgjjdIan7kU=; b=hAgWvP4n731epzKA0pvj7kqXXI4xpZpzIGLiHKK79f6hFmQ9HjBvMvmFtz4jKghv2o55bDMiDdNjMhUmrzgfgDmRSIYlP+GjnJOhdTHCw/RaVm3h2oJyMqE0qp83X5KQydkKnDrQmoPoMTXnO1gWIaQgB9sFrbO0JmQiN2SfCIM= Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-sn1nam04lp2057.outbound.protection.outlook.com [104.47.44.57]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-173-b9wQPVLvNemYOluZqV9nDw-1; Mon, 07 Jan 2019 14:18:19 -0500 Received: from CO2PR04CA0109.namprd04.prod.outlook.com (2603:10b6:104:7::11) by BN3PR0401MB1426.namprd04.prod.outlook.com (2a01:111:e400:4043::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1495.7; Mon, 7 Jan 2019 19:18:17 +0000 Received: from CO1NAM05FT056.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e50::204) by CO2PR04CA0109.outlook.office365.com (2603:10b6:104:7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1495.6 via Frontend Transport; Mon, 7 Jan 2019 19:18:16 +0000 Received: from owamail.extremenetworks.com (134.141.9.1) by CO1NAM05FT056.mail.protection.outlook.com (10.152.96.172) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1471.7 via Frontend Transport; Mon, 7 Jan 2019 19:18:15 +0000 Received: from USNC-CASHT-P2.corp.extremenetworks.com (10.6.17.62) by USNC-CASHT-P1.corp.extremenetworks.com (10.6.17.63) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Mon, 7 Jan 2019 14:18:14 -0500 Received: from smtp2.extremenetworks.com (10.6.25.34) by USNC-CASHT-P2.corp.extremenetworks.com (10.6.17.64) with Microsoft SMTP Server (TLS) id 15.0.1210.3 via Frontend Transport; Mon, 7 Jan 2019 14:18:14 -0500 Received: from macsec1.extremenetworks.com (a10-smtp.extremenetworks.com [10.6.24.14]) by smtp2.extremenetworks.com (8.13.8/8.13.8) with ESMTP id x07JICns010026; Mon, 7 Jan 2019 11:18:12 -0800 Received: from macsec1.extremenetworks.com (localhost [127.0.0.1]) by macsec1.extremenetworks.com (Postfix) with ESMTP id 18B861E20CE; Mon, 7 Jan 2019 19:18:26 -0500 (EST) Received: (from msiedzik@localhost) by macsec1.extremenetworks.com (8.14.7/8.14.7/Submit) id x080IPNK008570; Mon, 7 Jan 2019 19:18:25 -0500 From: To: Subject: [PATCH] mka: New MI should only be generated when peer's key is invalid Date: Mon, 7 Jan 2019 19:18:23 -0500 Message-ID: <1546906703-8529-1-git-send-email-msiedzik@extremenetworks.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:134.141.9.1; IPV:CAL; SCL:-1; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(396003)(346002)(39860400002)(376002)(136003)(2980300002)(38564003)(199004)(189003)(7636002)(336012)(2906002)(7596002)(186003)(305945005)(476003)(126002)(486006)(2616005)(5660300001)(14444005)(26005)(2351001)(106466001)(4720700003)(8746002)(8936002)(6916009)(51416003)(87636003)(47776003)(50466002)(48376002)(478600001)(5024004)(246002)(8676002)(26826003)(6306002)(966005)(50226002)(36756003)(575784001)(2876002)(4326008)(86362001)(107886003)(42186006)(426003)(106002)(86152003)(356004)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR0401MB1426; H:owamail.extremenetworks.com; FPR:; SPF:Pass; LANG:en; PTR:owamail.extremenetworks.com; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; CO1NAM05FT056; 1:R5fRtD7mnO+cjJG5L+l8ZuF9AhkqsmvY9F8+bAdzqyXGVNIbcsB8oqoPihFrffKuigqJSeEGLwMuSPpzRsZeU+rXLmsqnXKuNoApmwFW4fkLCzmTHWYbikko/ZmaXueI X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 48e656bd-f521-4da0-2422-08d674d4e009 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4608076)(4709027)(2017052603328)(7153060); SRVR:BN3PR0401MB1426; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0401MB1426; 3:JdqC0lP1wHEmmTqvwudyhWJmAx/mfBY8Yjmtbpi3Tg1MKnQfnT/f1f6hNUN1sJVC4DVe0EsqKNNjqIaChQO8UW7dgAv6NihYYW118s5LQLzFdPdsQ5ij6fxIpo7JNDtRQb9zK+Sn/NZi/xmn5+e8Wmqci5MK4hKq1uoacRP90ptmRDOK32Ygkv5ksdXIBNFyJc3P5qAkkNGHxQWSi5Pn1k8jdvIAEkrZEMFsH7e9OhTquvXfvupgZuPZq7weop/ZReDBY8TA1b/sWlJqo7UQ4uZqBngU+JFbX/QJqzJq3hrXKcSRPK8uxvZq55X+mf6E9Bu/hv6IOSb4hUU0zv/4alChxYlmz0vgypGpDhZVNeZMd6vWjiDEy6uYFOr2aB6q; 25:KCfX3lDy7pM3dkpuypLmbDaGWKTL0rJcEQCRs4XMKLZD4JsVc95EhqgrpGm35YCkTqG8iqUejSosE2B8caCYFtsC+TFXL78MBw3G0LTz1YJTcYz+emZCx5fiQiT0BNf7f6JMlDfZsdoMz1guz+OaZZ/aVuGdy0MNEb+w4tS3dUknq4tSimRPTRxzOlMFnidBWpgJd4xJoD0e3AMbFkh7S7vJq3ug/KKwSRw6Ew3BSjlpUHUkMf1gItUroMWs+zbAaLwi/u2jKKpk1TVrRAz4QA2OAtA1l9Csb3MYfFoPRfFTCTz09zvKIFI8Xp+wSgwxtkGTRXJLLU4PgrUH7bot+w== X-MS-TrafficTypeDiagnostic: BN3PR0401MB1426: X-Microsoft-Exchange-Diagnostics: 1; BN3PR0401MB1426; 31:hRIVKAitmUaA26h3RZVvGZ5JVHXsuIxApUnltk601R1sVcDNuTvG1RiBGDk1kbhVICs9OukxNevwpj/wbHODc/98N2JjuJZwD+MYbtmquSaZ+lZz0cFL3x1NnIZl2LEjUClf15xMevFXz8PFTv9j2nwyYdqQe8mS0x2NEIg4t/nIQYWFigOvHnQj13u3Egn5tH6Mm9K+EGoPJoSR8jJ8Ar+SsJuDYEdwwEyQ9NI8MO0=; 20:AT3R6ssoyn6WUPusyLgxoP1o0srur6Ud0A3dgdercpW5tKYD5ij2qU/dEJXEli3C5FNWmEChOHXU77mxbdLcSydARPKP5fqIXSvdahF6HR8tUi8Vqrk5ZXXD6nVuIGIYVZ6jk/gpWP7BAvWaXTt9PkvuNKdKaCsV2o9he9HUK6evYeGZXgqGimA2wQh72UtgB0RFLVbm0BwVrHh+1PlClY7MzysucIqnTaLMeJeoGSkH3gF3SaiiIhE6ahvVYZCE8OC9V9fN/ZtNk7W/9dbtkXSgsuG6r1uEQP/Iq2A2jye+BNrqMNMJMn0DF4b4lp3U4F8HrJyLZGg//gui6LdYw6Ig7+tDpE98bxXMWEo6V/U89r89U8T+jeYfupUFndf81gmSc8Crz6AYBpWIgDm08z0T+isbczcjtkaBeMxVIU0LEKEtRHIOqwN12rDzqUjJeRS8vJNpxctOVLf9dReSyRhXUGfT3Y+Mdlgb9W7jlyvDuB+oUzMI0mbGiyWtUmpp4NZejrI55426pit+Bq+OQ0reDvjxm7NWgjkUvm7ofKRva3VmQI4MtuqSxUk3hTZ+Ky1u98aXc9Vspb0pLaKSfvfiTUUTzxWWxz+3+bjQZjg= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(8220060)(2401047)(8121501046)(3231475)(944501520)(52105112)(93006095)(93004095)(10201501046)(3002001)(6041310)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(201708071742011)(7699051)(76991095); SRVR:BN3PR0401MB1426; BCL:0; PCL:0; RULEID:; SRVR:BN3PR0401MB1426; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0401MB1426; 4:PtA8zRohgvvbYFTnZy5iI/VVsbx4yQLFm58fVoF3X9WSCHrDSFt2HhMI/A4Y2pp1cpNOCbRibiK0AwLP8326XhZnmheIsRFBPZz7RtLcYccMOBTOhc7LhRfeEcH4sfakLWDCnD0qSvxsLwRg4/bmigEiVpQgKWv4U4NxVFL3YZ4g+3BOOX2mfS3oQa0YU+gT2GN9Q6qkAYbg9UKLZl0laKL1/MysiK0kaqBa4Ores7PSAOH/BsMOOISVT9jnxNRe5kMf2LV6AzSUOiwPC1J/+SADMwlb+JXjIoYmKupZU8jI8oBt+aB9UriBG9kYVDSV X-Forefront-PRVS: 0910AAF391 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR0401MB1426; 23:az9rwHUyENb5aNzXJa1gNvT3q2ZFL6X6Mn/8k9S?= 9bq0CpdrxhGDvDvy8D1cxy/t1wz/OUbdvxMVC9IukBTeJ9r3aMdAwSwQk3xeSwidYY5HhOI9XnkYJWxhj2SH3zqEwO9nvcXs9w1hf/0mn2wB6duLEvo40Gv4Yd21MNKfQlpSrS1/A8NyRxF90KVhknUqbDjw21Dt0OBik/i/8MrjxXhUgYDtAQoFuWp5FoqlDU30LUMOno/DuXJloCk/shbRy+VPny4OMXpGPp0+lHhc5i9MVWrnfox0zIXSGwqgjniBDBLBkcsdTxifdZ+GmUfR0jR3JYvQH+/p5JuQpJrzx7aEGs7Rpir249WNKT13sqXINBSZDyr0+YZlnNHWbt+rmi7O4jdVKnQZR8HNxXHUnsZvGMXvrWNIGA+v3oET3mBQTVgklVZduGfa3zLmcOgZPN2O1BXuW3hvBMkWmw2wrd5J7zpCjOd/nC8SBds9i5q8Uylp3aZTIHM8YnVOUyeP7eVjeXsLdSpcdcOqryXgiKLb9+DT+XnaSio0EykIeopNsKOK6YJcnIF+Y0bzMdSAKfrB8Nb1YdY9OL1Ccu702BGi46FO7qVX8gz2gXwYb2dIkP+2k4N1191xgdfKUjv1AcOjItMfwacDaZkJsS4QRquZx8cGUaUB3I3semDA1dLUYW84//JjruSM6oJ9HNZYhydoO1ZK2lTJwk4NiXVisQQ9g2p4kvCdLDjXPbhc7uY25RomPY1vpEs5ONNqwEB5uga9bWz05kwLlVvXXpUb9QCesr4KOGfXIvxNtO35SMhjeX4Cc+bVSF3IHrshDKw9k2nEepHmyYDi8Ko+BYZi9UHXHby+jKOVu5f5GvncNczRDAb5cp7peyImjSfrqs4tRy7/XfvnZQsgm1gqyRmRQ1we7dWreRw+GnWZxZz+Qcle8gSxZDFGZVARnW4lP+0QNllSIxo4tZH7OZvLbZyd8/vuzGtbuCP4EdAA6Pnzv1AdLIPEKBwe3/AWWYl2ipRx51d6yPWseJKQhGshKnv2KmDxUzT8IiZcBHf1AGBXAz1oPFqs7iH7xlsIBq+l+OJksfEoICnMv8WKf89wSq2AaoJKex4OHVEv+Zm+5qs+gPIJwVo6AGOPOg9eoZMsbT03O+FxAL8wViAZkeZCTIuevAg== X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: 5h1dbbV6L+DbLV8xkUzhTUSOp9ua5QZikhWyCZxlZllQQb7XD4pVh3thP4AXd5FuLbgOmRx7AEmIoOjCg9Rukvgb56gcQNiFzJ69iqH4lFzKeOssIBrHahtzdkBr+1Pxqr8XGaPKCPr8PQzE4vfrwgW52jK3A6ZV8tlhkaqqDkLORjbdQdo46mAmGQnng5ogU/1C728iJNgV/C+fz05IJYmWU16veCXSbn4WV7wg8v2mKlKWiyDvCkbP1Ce/ubywbt2AkrqLVeiXGCWNDPoIM4pPdjPlKBaRG9s4uBhLcOcwRjhXeGjuxSOcm9iEYW7Q X-Microsoft-Exchange-Diagnostics: 1; BN3PR0401MB1426; 6:bNbJ+D+IdkMDzQZcJWkd7Fo6/fncxuyGLvaxDmTD6ihpXBWvtwKG+If3IESQvY1apKD4Ng1e+h40gkEbAAlk3FqeSjFMkprzWxAVy5R/1FNoeD7YORGEqPjgFb1C++YB6+3wJmkuigDYums897uYI92Iwl2GKPRBR1JRbc21caUMl0ciWs+JrfV1+Lb6KmtD8IW8Vyi0MErCnAHte2PYLOplwQWOcsAhQeZbvjJQlQC8X6VFQVoHJnidXh/8JUSjmJACvbc8o7zlghXuz0tb9vtz/y1xvo2toVQ0sUtfyt/Ls+Q0kcboJ04oyi7xp9jakLVjtTe5OsPJuvdHlxAOsgzTG86qVUTLLIgABbfKTZ1sB/rWjg/QG7e9HFJS8g0pmtuAvcbxvSOA1jzLyWwrYadPTtROFywAB1F+Nq3Nxhn8dW1e6L+RELVMaEPSM9qXz8saVOdwWlL6sauPzRxbIg==; 5:lNy4caA/6AB+ZI4dZe0dTU3Q1bE/AbR/s2w/Ai95vozvHK8+FGO7xRGeKakfeDDXT6Zwsst+zVdC/GHWViEZcNQY5WzM0OVnThRb/iYmnQc6UN+fILD1vj5Ze05PXovNJSESL/RSJczKI14OuFT31v8w+ZD16SmOuX9ru01Mn0CI7fuTfD8LKc/8YX6l5ne2IT506yaqG2sMfzoKNqmbeg==; 7:baMD6JbDuw2wTVhxao9eJ1JfPODm5ukJT4IGy7y8lc3+eTb/e1L/Ai2BU+NMsoMqgr4E8TJRoFGBs3Nr1feWwAHALNwrZfe9QLAwt1hmPSuSKl54HSXhXS3fpa4Fq2MFJiFZxMYYVLx+V2XR4DRwdw== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: extremenetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2019 19:18:15.6181 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 48e656bd-f521-4da0-2422-08d674d4e009 X-MS-Exchange-CrossTenant-Id: fc8c2bf6-914d-4c1f-b352-46a9adb87030 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fc8c2bf6-914d-4c1f-b352-46a9adb87030; Ip=[134.141.9.1]; Helo=[owamail.extremenetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0401MB1426 X-MS-Exchange-CrossPremises-OriginalClientIPAddress: 134.141.9.1 X-MS-Exchange-CrossPremises-SCL: 1 X-MS-Exchange-CrossPremises-AuthSource: CO1NAM05FT056.eop-nam05.prod.protection.outlook.com X-MS-Exchange-CrossPremises-AuthAs: Anonymous X-MS-Exchange-CrossPremises-TransportTrafficType: Email X-MS-Exchange-CrossPremises-TransportTrafficSubType: X-MS-Exchange-CrossPremises-Antispam-ScanContext: DIR:Originating; SFV:NSPM; SKIP:0; X-MS-Exchange-CrossPremises-Processed-By-Journaling: Journal Agent X-OrganizationHeadersPreserved: BN3PR0401MB1426.namprd04.prod.outlook.com X-MC-Unique: b9wQPVLvNemYOluZqV9nDw-1 X-Mimecast-Spam-Score: 0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190107_111825_318679_FD86BF2F X-CRM114-Status: UNSURE ( 7.52 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -5.5 (-----) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-5.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [216.205.24.183 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -4.6 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mike Siedzik Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Mike Siedzik Two recent changes to MKA create a situation where a new MI is generated every time a SAK Use parameter set is decoded. The first change moved invalid key detection from ieee802_1x_decode_basic_body() to ieee802_1x_kay_decode_mpkdu(): https://w1.fi/cgit/hostap/commit/?id=db9ca18bbff101da67c0cd7f482fe29ae694dc04 The second change forces the KaY to generate a new MI when an invalid key is detected: https://w1.fi/cgit/hostap/commit/?id=a8aeaf41df95ac6f979eb9014d0e2d17c46c671e The fix is to move generation of a new MI from the old invalid key detection location to the new location. --- src/pae/ieee802_1x_kay.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 1.8.3.1 diff --git a/src/pae/ieee802_1x_kay.c b/src/pae/ieee802_1x_kay.c index c9948b7..b4455c8 100644 --- a/src/pae/ieee802_1x_kay.c +++ b/src/pae/ieee802_1x_kay.c @@ -1422,12 +1422,6 @@ ieee802_1x_mka_decode_sak_use_body( } if (!found) { wpa_printf(MSG_INFO, "KaY: Latest key is invalid"); - if (!reset_participant_mi(participant)) - wpa_printf(MSG_DEBUG, "KaY: Could not update mi"); - else - wpa_printf(MSG_DEBUG, - "KaY: Selected a new random MI: %s", - mi_txt(participant->mi)); return -1; } if (os_memcmp(participant->lki.mi, body->lsrv_mi, @@ -3289,6 +3283,12 @@ static int ieee802_1x_kay_decode_mkpdu(struct ieee802_1x_kay *kay, wpa_printf(MSG_INFO, "KaY: Discarding Rx MKPDU: decode of parameter set type (%d) failed", MKA_SAK_USE); + if (!reset_participant_mi(participant)) + wpa_printf(MSG_DEBUG, "KaY: Could not update mi"); + else + wpa_printf(MSG_DEBUG, + "KaY: Selected a new random MI: %s", + mi_txt(participant->mi)); return -1; }