diff mbox

DPP: Fix compilation without openssl

Message ID 1499279107-12997-3-git-send-email-andrei.otcheretianski@intel.com
State Accepted
Headers show

Commit Message

Andrei Otcheretianski July 5, 2017, 6:25 p.m. UTC 
dpp.h file requires openssl in order to compile, which breaks
compilation on systems without it.
Move DPP_OUI_TYPE to ieee802_11_defs.h and don't include dpp.h when
not really needed.

Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
---
 src/ap/drv_callbacks.c       | 1 -
 src/ap/gas_serv.c            | 1 -
 src/ap/ieee802_11.c          | 1 -
 src/common/dpp.h             | 3 ---
 src/common/ieee802_11_defs.h | 3 +++
 wpa_supplicant/events.c      | 1 -
 6 files changed, 3 insertions(+), 7 deletions(-)

Comments

Jouni Malinen July 7, 2017, 9:03 p.m. UTC | #1 
On Wed, Jul 05, 2017 at 09:25:07PM +0300, Andrei Otcheretianski wrote:
> dpp.h file requires openssl in order to compile, which breaks
> compilation on systems without it.
> Move DPP_OUI_TYPE to ieee802_11_defs.h and don't include dpp.h when
> not really needed.

Thanks, applied.
diff mbox

Patch

diff --git a/src/ap/drv_callbacks.c b/src/ap/drv_callbacks.c
index 9e30abf..1deaae6 100644
--- a/src/ap/drv_callbacks.c
+++ b/src/ap/drv_callbacks.c
@@ -14,7 +14,6 @@ 
 #include "drivers/driver.h"
 #include "common/ieee802_11_defs.h"
 #include "common/ieee802_11_common.h"
-#include "common/dpp.h"
 #include "common/wpa_ctrl.h"
 #include "crypto/random.h"
 #include "p2p/p2p.h"
diff --git a/src/ap/gas_serv.c b/src/ap/gas_serv.c
index e3068ef..fadb740 100644
--- a/src/ap/gas_serv.c
+++ b/src/ap/gas_serv.c
@@ -11,7 +11,6 @@ 
 #include "common.h"
 #include "common/ieee802_11_defs.h"
 #include "common/gas.h"
-#include "common/dpp.h"
 #include "common/wpa_ctrl.h"
 #include "utils/eloop.h"
 #include "hostapd.h"
diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c
index 8069c36..3964c45 100644
--- a/src/ap/ieee802_11.c
+++ b/src/ap/ieee802_11.c
@@ -19,7 +19,6 @@ 
 #include "common/ieee802_11_common.h"
 #include "common/wpa_ctrl.h"
 #include "common/sae.h"
-#include "common/dpp.h"
 #include "radius/radius.h"
 #include "radius/radius_client.h"
 #include "p2p/p2p.h"
diff --git a/src/common/dpp.h b/src/common/dpp.h
index 4a53c5d..c328e1d 100644
--- a/src/common/dpp.h
+++ b/src/common/dpp.h
@@ -15,9 +15,6 @@ 
 #include "common/wpa_common.h"
 #include "crypto/sha256.h"
 
-/* DPP Public Action frame identifiers - OUI_WFA */
-#define DPP_OUI_TYPE 0x1A
-
 enum dpp_public_action_frame_type {
 	DPP_PA_AUTHENTICATION_REQ = 0,
 	DPP_PA_AUTHENTICATION_RESP = 1,
diff --git a/src/common/ieee802_11_defs.h b/src/common/ieee802_11_defs.h
index 6be71fe..393d496 100644
--- a/src/common/ieee802_11_defs.h
+++ b/src/common/ieee802_11_defs.h
@@ -2025,4 +2025,7 @@  struct ieee80211_he_operation {
 #define HE_OPERATION_BSS_COLOR_DISABLED		((u32) BIT(30))
 #define HE_OPERATION_BSS_DUAL_BEACON		((u32) BIT(31))
 
+/* DPP Public Action frame identifiers - OUI_WFA */
+#define DPP_OUI_TYPE 0x1A
+
 #endif /* IEEE802_11_DEFS_H */
diff --git a/wpa_supplicant/events.c b/wpa_supplicant/events.c
index 5b053c1..7059dac 100644
--- a/wpa_supplicant/events.c
+++ b/wpa_supplicant/events.c
@@ -28,7 +28,6 @@ 
 #include "notify.h"
 #include "common/ieee802_11_defs.h"
 #include "common/ieee802_11_common.h"
-#include "common/dpp.h"
 #include "common/gas_server.h"
 #include "crypto/random.h"
 #include "blacklist.h"