From patchwork Wed Jun 8 19:01:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Afek X-Patchwork-Id: 632456 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rPyVR20Xcz9sCk for ; Thu, 9 Jun 2016 05:02:23 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wizery-com.20150623.gappssmtp.com header.i=@wizery-com.20150623.gappssmtp.com header.b=UUUbgUWZ; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1bAijy-0006oU-CB; Wed, 08 Jun 2016 19:02:10 +0000 Received: from mail-pa0-x242.google.com ([2607:f8b0:400e:c03::242]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1bAijv-0006mK-Tk for hostap@lists.infradead.org; Wed, 08 Jun 2016 19:02:08 +0000 Received: by mail-pa0-x242.google.com with SMTP id ug1so1075721pab.1 for ; Wed, 08 Jun 2016 12:01:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wizery-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=Y98BVeHsxv0wd2JikE7qVW1LCi5gkH0d/44LrhplDu0=; b=UUUbgUWZ6NhR2IIjhKjvqUPd7Y1rGYXlfwrQKd3Be28Cz6L4lNMZ2xIkfccZ9YmDO5 ful3HAIakasXve9u/EHz6NqJqe9zqeBtbGGnCPQuhI+L975NNTFYqweCm+CKi2BKf1C0 u6TksVv64pv8MkHJW8e+/DcZH+qiX+rGq+cSCWWmYzQ58xCioDQjIiSvx7uJi6cZg9eJ 8ug+cNs4lt3e11nfV/xlgtsBrBwULQe7WVyE3JZOTN8yO5KBhMO6fCwA9VAQyw99AF8V dImGc3KJn0mGC99V7eJwtQXMhJePqExJZVnUqEjbv7kwTCIRqPviWfCVss8Q/loqa4bh RjPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=Y98BVeHsxv0wd2JikE7qVW1LCi5gkH0d/44LrhplDu0=; b=G6o/8JDx5N6/9BBf8jodjxJIM4EyH1n91j8VMXheX4hlDXoxG40k+Eikrds6mrNjTb FVaDeUcH41ZXBytq+Yx8gTFaFXatAhcBAUsCJans9Fu37Xl56rZrvIdjS5uYpaEOs+HZ YHCzJsUEwuyGzKgzkIKnIYZ3MGsECQS+Zvu3j1Ah2k2LlAKN9YuTn+c+5aJ2MvSXzs/l VqUuh9YhqPYOo69QxtchDapLwouUGMgSloN7r3Z6458q9s1c+j6l2oznQfteyVj5kTYL YcjJXMUyDyLr38MjyZGOF5K4VQdmvlXA4nvQog48NBDvWoifg69C2v0U6AZ1tj4xBEdp 2Vig== X-Gm-Message-State: ALyK8tJhNXzW1uzd1+OVFTBcSP7zMV1qnH9XrPdE26bpUW9yrvYWKDrDqUz7LWsOENpk0Q== X-Received: by 10.66.84.74 with SMTP id w10mr7223655pay.140.1465412506820; Wed, 08 Jun 2016 12:01:46 -0700 (PDT) Received: from localhost.localdomain ([192.55.54.43]) by smtp.gmail.com with ESMTPSA id bm8sm4186233pad.10.2016.06.08.12.01.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 08 Jun 2016 12:01:46 -0700 (PDT) From: Jonathan Afek To: hostap@lists.infradead.org Subject: [PATCH 1/2] ctrl_iface: BSS command return FAIL on no data Date: Wed, 8 Jun 2016 22:01:37 +0300 Message-Id: <1465412498-32289-1-git-send-email-jonathan@wizery.com> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160608_120208_049550_196C3DB9 X-CRM114-Status: UNSURE ( 9.22 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2607:f8b0:400e:c03:0:0:0:242 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The BSS supplicant command returns a 0 len reply when failing to pasrse some information for a BSS. This patch make the function wpa_supplicant_ctrl_iface_bss() return -1 on such cases instead of 0 and therefore the BSS command will return FAIL. This is important since when using udp control interfaces sending a 0 len reply does not send a reply at all and the control interface can wait forever (or until a timeout is reached) for a reply. Signed-off-by: Jonathan Afek --- wpa_supplicant/ctrl_iface.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/wpa_supplicant/ctrl_iface.c b/wpa_supplicant/ctrl_iface.c index 2ff47cb..401cd61 100644 --- a/wpa_supplicant/ctrl_iface.c +++ b/wpa_supplicant/ctrl_iface.c @@ -4560,6 +4560,8 @@ static int wpa_supplicant_ctrl_iface_bss(struct wpa_supplicant *wpa_s, bss = dl_list_entry(next, struct wpa_bss, list_id); } while (bss && len); + if (0 == ret) + return -1; return ret; }