From patchwork Tue Jun 7 13:42:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Afek X-Patchwork-Id: 631628 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rPCT71kRmz9sBR for ; Tue, 7 Jun 2016 23:43:39 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wizery-com.20150623.gappssmtp.com header.i=@wizery-com.20150623.gappssmtp.com header.b=Y6INOdAx; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1bAHHm-0000JH-Us; Tue, 07 Jun 2016 13:43:14 +0000 Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1bAHHk-0008W4-QC for hostap@lists.infradead.org; Tue, 07 Jun 2016 13:43:13 +0000 Received: by mail-pf0-x241.google.com with SMTP id l188so3836360pfl.1 for ; Tue, 07 Jun 2016 06:42:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wizery-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=hDtlNGBzviqbcfPVOc1TJw4oz2lUOUGJ4g9mH4L2Ics=; b=Y6INOdAxLLxPUSDoyfuh5nAtGuYBkXJwi0807y4vHT0Bj+MvSAfotXB6bhlFmM57L9 Wtf6WIGgtP5VNB3mKMFEk/SCsLNvRt3vsAfyKDUf6wcL22QEIzP+TxcZj8Wulm/uTaMn tFlLM7rMj6v5/DaBAQb+W+hVS7GXeQ9EuKoYkBB9b+Q2QR/jnOJ8uxgp6R8Ym6yjn7Dh vsN2E/1YEYinFFUtgnMnvG9MJdqPBSKV6zek1jKTPR5PI5DWrG81lWlp2R2I8nI46C8S CNUuco7Ekf1GpGlAH2YJQg6V5ZPf/y+4UTmAuQJzKV7kPWL0g8rdT+I6DdfjXCcSVwXe B2gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=hDtlNGBzviqbcfPVOc1TJw4oz2lUOUGJ4g9mH4L2Ics=; b=m4AL2EdpSp15alvunC39TKXYyoWHjtNQJWwbcMbBT5lCrDFRUnjfKFt7u5IxJ6J32f y9gcdGFekW3ur7tBgUpJiRRHDuVrnOb7q5hhT7p7ffvhMW1+CNdX6P5IeYLyxLes6Xe2 0N5rHDIx4hJLucG62FeB84HqSrG/9oVxzRnJ4zxO963UWsvFLWcfqM38bwIu2E7Y0CSp 0q/y/cZ8Dgi54i4pm/YUO7wANwdEYHuJPnYjgGDkphSREqxKzwpmcUZv1stn7sz/X3nS jW+5AXUBftzidrggd6DWO4+3KTHbqRNQASumRQsfudqBsSxEJoL4r0xx1/0wg371zXzt 3GRw== X-Gm-Message-State: ALyK8tLsTsGVP3H2uB05zY5plzoOSdD06bA5SEgMCjoleT8LMulG18EYxwjq39qepBQBFQ== X-Received: by 10.98.135.6 with SMTP id i6mr6703491pfe.3.1465306970984; Tue, 07 Jun 2016 06:42:50 -0700 (PDT) Received: from localhost.localdomain ([192.55.54.44]) by smtp.gmail.com with ESMTPSA id hk7sm33395712pad.25.2016.06.07.06.42.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 07 Jun 2016 06:42:50 -0700 (PDT) From: Jonathan Afek To: hostap@lists.infradead.org Subject: [PATCH 1/6] ctrl_iface: BSS command return FAIL on failure Date: Tue, 7 Jun 2016 16:42:38 +0300 Message-Id: <1465306963-22464-1-git-send-email-jonathan@wizery.com> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160607_064312_973575_C4DA7189 X-CRM114-Status: GOOD ( 12.20 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2607:f8b0:400e:c00:0:0:0:241 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The BSS supplicant command returns a 0 len reply on a failure when the BSS isn't in the DB or if the command has invalid params. This patch make the function wpa_supplicant_ctrl_iface_bss() return -1 on failures instead of 0 and therefore the BSS command will return FAIL on failures. This is important since when using udp control interfaces sending a 0 len reply does not send a reply at all and the control interface can wait forever (or until a timeout is reached) for a reply. Signed-off-by: Jonathan Afek --- wpa_supplicant/ctrl_iface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/wpa_supplicant/ctrl_iface.c b/wpa_supplicant/ctrl_iface.c index e75f1ae..2ff47cb 100644 --- a/wpa_supplicant/ctrl_iface.c +++ b/wpa_supplicant/ctrl_iface.c @@ -4448,7 +4448,7 @@ static int wpa_supplicant_ctrl_iface_bss(struct wpa_supplicant *wpa_s, if ((ctmp = os_strchr(cmd + 6, '-')) == NULL) { wpa_printf(MSG_INFO, "Wrong BSS range " "format"); - return 0; + return -1; } if (*(cmd + 6) == '-') @@ -4530,7 +4530,7 @@ static int wpa_supplicant_ctrl_iface_bss(struct wpa_supplicant *wpa_s, } if (bss == NULL) - return 0; + return -1; if (bsslast == NULL) bsslast = bss;