diff mbox

Disabling SMPS (Spatial multiplexing power save) when 802.11n is not used

Message ID 1458289249-5011-1-git-send-email-blanquicet@gmail.com
State Superseded
Headers show

Commit Message

Jose Blanquicet March 18, 2016, 8:20 a.m. UTC 
Instead of clean the HT Capabilities by setting it to zero, it should be
set to HT_CAP_INFO_SMPS_DISABLED to avoid erros in a non-802.11n mode,
followign the PATCH:
 
---
 wpa_supplicant/ap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Johannes Berg March 18, 2016, 12:25 p.m. UTC | #1 
On Fri, 2016-03-18 at 09:20 +0100, Jose Blanquicet wrote:
> Instead of clean the HT Capabilities by setting it to zero, it should
> be
> set to HT_CAP_INFO_SMPS_DISABLED to avoid erros in a non-802.11n
> mode,
> followign the PATCH:
>  
> ---
>  wpa_supplicant/ap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/wpa_supplicant/ap.c b/wpa_supplicant/ap.c
> index fd5b03f..824993d 100644
> --- a/wpa_supplicant/ap.c
> +++ b/wpa_supplicant/ap.c
> @@ -133,7 +133,7 @@ int wpa_supplicant_conf_ap_ht(struct
> wpa_supplicant *wpa_s,
>  #ifdef CONFIG_HT_OVERRIDES
>  		if (ssid->disable_ht) {
>  			conf->ieee80211n = 0;
> -			conf->ht_capab = 0;
> +			conf->ht_capab = HT_CAP_INFO_SMPS_DISABLED;;


Double semicolon?

But in any case, this seems pointless since if ieee80211n is 0, we
should never add HT IEs anywhere?

johannes
diff mbox

Patch

diff --git a/wpa_supplicant/ap.c b/wpa_supplicant/ap.c
index fd5b03f..824993d 100644
--- a/wpa_supplicant/ap.c
+++ b/wpa_supplicant/ap.c
@@ -133,7 +133,7 @@  int wpa_supplicant_conf_ap_ht(struct wpa_supplicant *wpa_s,
 #ifdef CONFIG_HT_OVERRIDES
 		if (ssid->disable_ht) {
 			conf->ieee80211n = 0;
-			conf->ht_capab = 0;
+			conf->ht_capab = HT_CAP_INFO_SMPS_DISABLED;;
 			no_ht = 1;
 		}
 #endif /* CONFIG_HT_OVERRIDES */