diff mbox

HS 2.0R2: Clear fetch_anqp_in_progress when fopen is failed

Message ID 1456856798-2096-1-git-send-email-daichi.ueura@sonymobile.com
State Accepted
Headers show

Commit Message

Daichi Ueura March 1, 2016, 6:26 p.m. UTC
Clear wpa_s->fetch_anqp_in_progress when osu-providers.txt can't be
opened. A issue happens, for instance, when wpa_supplicant doesn't
have correct access permission to the directory specified by osu_dir.
If hs20_osu_fetch_done method returns without clearing the flag,
'FETCH_OSU' command will never work correctly.

Signed-off-by: Daichi Ueura <daichi.ueura@sonymobile.com>
---
 wpa_supplicant/hs20_supplicant.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jouni Malinen March 3, 2016, 3:57 p.m. UTC | #1
On Wed, Mar 02, 2016 at 03:26:38AM +0900, Daichi Ueura wrote:
> Clear wpa_s->fetch_anqp_in_progress when osu-providers.txt can't be
> opened. A issue happens, for instance, when wpa_supplicant doesn't
> have correct access permission to the directory specified by osu_dir.
> If hs20_osu_fetch_done method returns without clearing the flag,
> 'FETCH_OSU' command will never work correctly.

Thanks, applied.
diff mbox

Patch

diff --git a/wpa_supplicant/hs20_supplicant.c b/wpa_supplicant/hs20_supplicant.c
index 57b9943..3128fcb 100644
--- a/wpa_supplicant/hs20_supplicant.c
+++ b/wpa_supplicant/hs20_supplicant.c
@@ -664,6 +664,7 @@  static void hs20_osu_fetch_done(struct wpa_supplicant *wpa_s)
 	f = fopen(fname, "w");
 	if (f == NULL) {
 		hs20_free_osu_prov(wpa_s);
+		wpa_s->fetch_anqp_in_progress = 0;
 		return;
 	}