diff mbox

EAP-IKEv2: Fix compilation warning

Message ID 1415177437-11016-2-git-send-email-ilan.peer@intel.com
State Accepted
Headers show

Commit Message

Peer, Ilan Nov. 5, 2014, 8:50 a.m. UTC 
From: Andrei Otcheretianski <andrei.otcheretianski@intel.com>

Fix signed/unsigned comparison compilation warning introduced in
08ef442 "EAP-IKEv2: Fix the payload parser".

Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
---
 src/eap_common/ikev2_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jouni Malinen Nov. 15, 2014, 2:02 p.m. UTC | #1 
On Wed, Nov 05, 2014 at 03:50:35AM -0500, Ilan Peer wrote:
> Fix signed/unsigned comparison compilation warning introduced in
> 08ef442 "EAP-IKEv2: Fix the payload parser".

Thanks, applied.
diff mbox

Patch

diff --git a/src/eap_common/ikev2_common.c b/src/eap_common/ikev2_common.c
index 4b5e665..262d9ab 100644
--- a/src/eap_common/ikev2_common.c
+++ b/src/eap_common/ikev2_common.c
@@ -263,7 +263,7 @@  int ikev2_parse_payloads(struct ikev2_payloads *payloads,
 		}
 		phdr = (const struct ikev2_payload_hdr *) pos;
 		plen = WPA_GET_BE16(phdr->payload_length);
-		if (plen < sizeof(*phdr) || plen > end - pos) {
+		if (plen < sizeof(*phdr) || pos + plen > end) {
 			wpa_printf(MSG_INFO, "IKEV2:   Invalid payload header "
 				   "length %d", plen);
 			return -1;