Message ID | 1410895247-1089-1-git-send-email-bernhard@bwalle.de |
---|---|
State | Accepted |
Headers | show |
On Tue, Sep 16, 2014 at 09:20:47PM +0200, Bernhard Walle wrote: > '\e' representing ESC (0x1b) is not C standard, it's an GNU extension. > https://gcc.gnu.org/onlinedocs/gcc/Character-Escapes.html#Character-Escapes > > Since the code also compiles on Windows with Microsoft compiler, we > should use '\033' instead. Thanks, applied.
diff --git a/src/utils/common.c b/src/utils/common.c index 5b017e5..7ef8b0a 100644 --- a/src/utils/common.c +++ b/src/utils/common.c @@ -362,7 +362,7 @@ void printf_encode(char *txt, size_t maxlen, const u8 *data, size_t len) *txt++ = '\\'; *txt++ = '\\'; break; - case '\e': + case '\033': *txt++ = '\\'; *txt++ = 'e'; break; @@ -427,7 +427,7 @@ size_t printf_decode(u8 *buf, size_t maxlen, const char *str) pos++; break; case 'e': - buf[len++] = '\e'; + buf[len++] = '\033'; pos++; break; case 'x':
'\e' representing ESC (0x1b) is not C standard, it's an GNU extension. https://gcc.gnu.org/onlinedocs/gcc/Character-Escapes.html#Character-Escapes Since the code also compiles on Windows with Microsoft compiler, we should use '\033' instead. Note: I didn't try to build the whole wpa_supplicant on Windows, so I don't know if it still builds (I have no Visual Studio 2005 for a quick test). I just needed the string conversion routines for the P"" syntax in both directions. Signed-off-by: Bernhard Walle <bernhard@bwalle.de> --- src/utils/common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)