diff mbox

nl80211: Register eloop after hs20 action frame

Message ID 1409541621-20211-1-git-send-email-eduardo.abinader@openbossa.org
State Accepted
Headers show

Commit Message

Eduardo Abinader Sept. 1, 2014, 3:20 a.m. UTC
Even when hs20 action frame is unable to be registered,
for whatever reason, it should be possible to register
event handle for received driver messages. This patch also
avoids a segmentation fault, when p2p and hs20 were enabled
and GO NEG was unable to create p2p iface, the destroy eloop
was crashing by reading an invalid handle.

Signed-off-by: Eduardo Abinader <eduardo.abinader@openbossa.org>
---
 src/drivers/driver_nl80211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jouni Malinen Sept. 8, 2014, 4:52 p.m. UTC | #1
On Sun, Aug 31, 2014 at 11:20:21PM -0400, Eduardo Abinader wrote:
> Even when hs20 action frame is unable to be registered,
> for whatever reason, it should be possible to register
> event handle for received driver messages. This patch also
> avoids a segmentation fault, when p2p and hs20 were enabled
> and GO NEG was unable to create p2p iface, the destroy eloop
> was crashing by reading an invalid handle.

Thanks, applied.
diff mbox

Patch

diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
index 8ebf7d9..e67a61e 100644
--- a/src/drivers/driver_nl80211.c
+++ b/src/drivers/driver_nl80211.c
@@ -4550,7 +4550,7 @@  static int nl80211_mgmt_subscribe_non_ap(struct i802_bss *bss)
 #ifdef CONFIG_HS20
 	/* WNM-Notification */
 	if (nl80211_register_action_frame(bss, (u8 *) "\x0a\x1a", 2) < 0)
-		return -1;
+		ret = -1;
 #endif /* CONFIG_HS20 */
 
 	nl80211_mgmt_handle_register_eloop(bss);