diff mbox

[1/1] hostapd_cli: fix seg fault for interface command

Message ID 1401399727-6558-1-git-send-email-eduardo.abinader@openbossa.org
State Accepted
Headers show

Commit Message

Eduardo Abinader May 29, 2014, 9:42 p.m. UTC
ctrl_ifname was not being freed and allocated
by proper functions: os_free and os_strdup.

Signed-off-by: Eduardo Abinader <eduardo.abinader@openbossa.org>
---
 hostapd/hostapd_cli.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jouni Malinen May 31, 2014, 9:49 a.m. UTC | #1
On Thu, May 29, 2014 at 05:42:07PM -0400, Eduardo Abinader wrote:
> ctrl_ifname was not being freed and allocated
> by proper functions: os_free and os_strdup.

Thanks, applied.
diff mbox

Patch

diff --git a/hostapd/hostapd_cli.c b/hostapd/hostapd_cli.c
index c488b4f..1c4a84c 100644
--- a/hostapd/hostapd_cli.c
+++ b/hostapd/hostapd_cli.c
@@ -842,8 +842,8 @@  static int hostapd_cli_cmd_interface(struct wpa_ctrl *ctrl, int argc,
 	}
 
 	hostapd_cli_close_connection();
-	free(ctrl_ifname);
-	ctrl_ifname = strdup(argv[0]);
+	os_free(ctrl_ifname);
+	ctrl_ifname = os_strdup(argv[0]);
 
 	if (hostapd_cli_open_connection(ctrl_ifname)) {
 		printf("Connected to interface '%s.\n", ctrl_ifname);