diff mbox

wpa_s: Fix a critical never-ending loop

Message ID 1386593275-23779-1-git-send-email-tomasz.bursztyka@linux.intel.com
State Accepted
Headers show

Commit Message

Tomasz Bursztyka Dec. 9, 2013, 12:47 p.m. UTC
commit 202dec2a94695a696236ee5a2ad1be0905ccea14 has introduced a never
ending loop. This patch fixes it: so it loops on all interfaces until it
hits a NULL pointer so it can leave the loop.

Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
---

 wpa_supplicant/wpa_supplicant.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jouni Malinen Dec. 15, 2013, 5:58 a.m. UTC | #1
On Mon, Dec 09, 2013 at 02:47:55PM +0200, Tomasz Bursztyka wrote:
> commit 202dec2a94695a696236ee5a2ad1be0905ccea14 has introduced a never
> ending loop. This patch fixes it: so it loops on all interfaces until it
> hits a NULL pointer so it can leave the loop.

Thanks, applied.
diff mbox

Patch

diff --git a/wpa_supplicant/wpa_supplicant.c b/wpa_supplicant/wpa_supplicant.c
index e8bca8a..2d6272b 100644
--- a/wpa_supplicant/wpa_supplicant.c
+++ b/wpa_supplicant/wpa_supplicant.c
@@ -2905,6 +2905,8 @@  static struct wpa_radio * radio_add_interface(struct wpa_supplicant *wpa_s,
 			dl_list_add(&radio->ifaces, &wpa_s->radio_list);
 			return radio;
 		}
+
+		iface = iface->next;
 	}
 
 	wpa_printf(MSG_DEBUG, "Add interface %s to a new radio %s",