diff mbox series

Question on external authentication in driver-based AP SME mode

Message ID 10c601d59089$fd7cee00$f876ca00$@samsung.com
State Not Applicable
Headers show
Series Question on external authentication in driver-based AP SME mode | expand

Commit Message

semun.lee Nov. 1, 2019, 7:57 a.m. UTC 
Hello folks,

Recently, I've adjusted wpa_supplicant 2.8 to my project and met an weird
issue when I tried to connect two devices as p2p mode. Anyway, I've found
that the patch which is related to the external authentication support is
related to the issue.

https://w1.fi/cgit/hostap/commit/?id=236e793e7b8b96f7ad3e9aa3ea83b7c7c83b43f
a

It changed to call nl80211_register_frame of WLAN_FC_STYPE_AUTH when
bss->drv->device_ap_sme is 1. What I want to know is that if
WLAN_FC_TYPE_AUTH should be registered always when bss->drv->device_ap_sme
is 1. I thought that it might be added for supporting SAE, but my driver
doesn't work properly because WLAN_FC_TYPE_AUTH is registered even when I
don't use SAE.

I'm sorry that I don't understand fully what the patch was for. Could you
share any idea on it?


 	nl80211_mgmt_handle_register_eloop(bss);
 	return 0;


Best regards,
Semun
diff mbox series

Patch

diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
index 661e34e..b934c84 100644
--- a/src/drivers/driver_nl80211.c
+++ b/src/drivers/driver_nl80211.c
@@ -2469,6 +2469,16 @@  static int nl80211_mgmt_subscribe_ap_dev_sme(struct
i802_bss *bss)
 	if (nl80211_action_subscribe_ap(bss))
 		goto out_err;
 
+	if (bss->drv->device_ap_sme) {
+		u16 type = (WLAN_FC_TYPE_MGMT << 2) | (WLAN_FC_STYPE_AUTH <<
4);
+
+		/* Register for all Authentication frames */
+		if (nl80211_register_frame(bss, bss->nl_mgmt, type, NULL, 0)
+		    < 0)
+			wpa_printf(MSG_DEBUG,
+				   "nl80211: Failed to subscribe to handle
Authentication frames - SAE offload may not work");
+	}
+