mbox series

[v4,0/7] Fix and unify wpa_supplicant AP/mesh frequency setup

Message ID 20200630115323.126143-1-markus.theil@tu-ilmenau.de
Headers show
Series Fix and unify wpa_supplicant AP/mesh frequency setup | expand

Message

Markus Theil June 30, 2020, 11:53 a.m. UTC
This series removes partially duplicated frequency setup code from mesh.c
and enhances wpa_supplicant_conf_ap_ht to perform at least the same config
settings.

wpa_supplicant_conf_ap_ht's call position in mesh.c is changed in order to have
effect before interface initialization.

20/40 coexistence for mesh networks is disabled, because it can not be decided
in a larger distributed setup, which is not booted at the same time, but with
some delay (network partitions will remain and not unify, see also longer comment
in the code of "mesh: fix channel init order, disable pri/sec channel switch").
Some form of partition detection and dynamic channel switching or distributed
consensus algorithm would be needed to resolve this issue, which IEEE 802.11
at this time not includes.

v4: better debug messages for hw_features channel setting
    use helpers in more places

v3: fix non p2p builds and secondary idx setting

v2: call wpa_supplicant_conf_ap_ht in the right place for mesh

Markus Theil (7):
  HE/VHT: fix frequency setup with HE enabled
  mesh: fix channel init order, disable pri/sec channel switch
  wpa_supplicant: handle HT40 and mode downgrade in AP mode
  wpa_supplicant: fix frequency config for non p2p vht/he cases
  wpa_supplicant: enable vht and he in default config parameters
  hw_features: better debug messages for some error cases
  dfs: use helper functions for vht/he parameters

 src/ap/dfs.c                    |  14 +++--
 src/common/hw_features_common.c |  29 ++++++---
 tests/hwsim/test_wpas_mesh.py   |  50 ----------------
 wpa_supplicant/ap.c             | 102 ++++++++++++++++++++++----------
 wpa_supplicant/config.c         |   2 +
 wpa_supplicant/mesh.c           |  49 +++++++--------
 6 files changed, 126 insertions(+), 120 deletions(-)

Comments

Jouni Malinen Oct. 14, 2020, 5:20 p.m. UTC | #1
On Tue, Jun 30, 2020 at 01:53:16PM +0200, Markus Theil wrote:
> This series removes partially duplicated frequency setup code from mesh.c
> and enhances wpa_supplicant_conf_ap_ht to perform at least the same config
> settings.
> 
> wpa_supplicant_conf_ap_ht's call position in mesh.c is changed in order to have
> effect before interface initialization.
> 
> 20/40 coexistence for mesh networks is disabled, because it can not be decided
> in a larger distributed setup, which is not booted at the same time, but with
> some delay (network partitions will remain and not unify, see also longer comment
> in the code of "mesh: fix channel init order, disable pri/sec channel switch").
> Some form of partition detection and dynamic channel switching or distributed
> consensus algorithm would be needed to resolve this issue, which IEEE 802.11
> at this time not includes.
> 
> v4: better debug messages for hw_features channel setting
>     use helpers in more places

Thanks, applied other patches except for 4/7:

>   wpa_supplicant: fix frequency config for non p2p vht/he cases

I have an open question on this related to impact on P2P.