mbox series

[0/4] Handle pre-auth over nl80211 control port

Message ID 20200113113735.32182-1-markus.theil@tu-ilmenau.de
Headers show
Series Handle pre-auth over nl80211 control port | expand

Message

Markus Theil Jan. 13, 2020, 11:37 a.m. UTC
In preparation for rx over nl80211 control port, this series adds
support for pre-auth handling. nl80211 control port rx forwards all EAPOL
and pre-auth frames over a nl socket if activated.

Markus Theil (4):
  driver: add rsn pre-auth rx event
  nl80211: differentiate between ETH_P_PAE and ETH_P_RSN_PREAUTH for
    control port rx
  wpa_supplicant: add support for pre-auth rx over driver event
  hostapd: add support for pre-auth rx over driver event

 src/ap/drv_callbacks.c             | 32 +++++++++++++++++++++++++
 src/ap/preauth_auth.c              | 29 +++++++++++++++++++++++
 src/ap/preauth_auth.h              | 13 ++++++++++
 src/drivers/driver.h               | 31 ++++++++++++++++++++++++
 src/drivers/driver_common.c        |  1 +
 src/drivers/driver_nl80211_event.c | 38 ++++++++++++++++++++++++------
 src/rsn_supp/preauth.c             |  4 ++--
 src/rsn_supp/preauth.h             |  7 ++++++
 wpa_supplicant/events.c            |  5 ++++
 wpa_supplicant/wpa_supplicant.c    | 28 ++++++++++++++++++++++
 wpa_supplicant/wpa_supplicant_i.h  |  2 ++
 11 files changed, 181 insertions(+), 9 deletions(-)

--
2.17.1

Comments

Jouni Malinen Feb. 23, 2020, 10:35 p.m. UTC | #1
On Mon, Jan 13, 2020 at 12:37:31PM +0100, Markus Theil wrote:
> In preparation for rx over nl80211 control port, this series adds
> support for pre-auth handling. nl80211 control port rx forwards all EAPOL
> and pre-auth frames over a nl socket if activated.

Why would EAPOL RX over nl80211 control port need RSN preauthentication
frames to use that same port? That does not sound like a reasonable
constraint to me taken into account completely different protocol rules
for EAPOL and RSN preauthentication frames.

>   driver: add rsn pre-auth rx event
>   nl80211: differentiate between ETH_P_PAE and ETH_P_RSN_PREAUTH for
>     control port rx
>   wpa_supplicant: add support for pre-auth rx over driver event
>   hostapd: add support for pre-auth rx over driver event

There would need to be pretty strong justification for accepting these..
In other words, I'm dropping these now and I'd like to get the EAPOL RX
over nl80211 control port working first before considering any changes
to RSN preauthentication frames.