mbox series

[v5,0/3] Expose MAC address randomization over D-Bus

Message ID 1571353432-230483-1-git-send-email-ejcaruso@chromium.org
Headers show
Series Expose MAC address randomization over D-Bus | expand

Message

Eric Caruso Oct. 17, 2019, 11:03 p.m. UTC 
This is a patch series to expose per-scan MAC address randomization
functionality over D-Bus. The D-Bus interface was previously given
the OK by Dan Williams and the memory leaks and hwsim failure pointed
out by Jouni Malinen have been fixed.

The last patch in the series fixes a bug where scans triggered by
D-Bus would not use the randomization settings that e.g. could have
previously been set up via the control interface. This is included
because users who want to set up MAC address randomization via the
D-Bus interface are also likely to be requesting scans via the D-Bus
interface (we do this on Chrome OS). After this patch, randomization
can be set up via either mechanism and used by either mechanism.

Eric Caruso (3):
  Move ownership of MAC address randomization mask to scan params
  Add MAC address randomization endpoints to D-Bus
  Allow scans triggered by D-Bus to use MAC address randomization

 doc/dbus.doxygen                        |   6 +
 wpa_supplicant/dbus/dbus_new.c          |   6 +
 wpa_supplicant/dbus/dbus_new_handlers.c | 154 ++++++++++++++++++++++++
 wpa_supplicant/dbus/dbus_new_handlers.h |   2 +
 wpa_supplicant/scan.c                   |  99 ++++++++++-----
 wpa_supplicant/scan.h                   |   2 +
 6 files changed, 236 insertions(+), 33 deletions(-)

Comments

Jouni Malinen Oct. 27, 2019, 5:55 p.m. UTC | #1 
On Thu, Oct 17, 2019 at 04:03:49PM -0700, Eric Caruso wrote:
> This is a patch series to expose per-scan MAC address randomization
> functionality over D-Bus. The D-Bus interface was previously given
> the OK by Dan Williams and the memory leaks and hwsim failure pointed
> out by Jouni Malinen have been fixed.
> 
> The last patch in the series fixes a bug where scans triggered by
> D-Bus would not use the randomization settings that e.g. could have
> previously been set up via the control interface. This is included
> because users who want to set up MAC address randomization via the
> D-Bus interface are also likely to be requesting scans via the D-Bus
> interface (we do this on Chrome OS). After this patch, randomization
> can be set up via either mechanism and used by either mechanism.
> 
> Eric Caruso (3):
>   Move ownership of MAC address randomization mask to scan params
>   Add MAC address randomization endpoints to D-Bus
>   Allow scans triggered by D-Bus to use MAC address randomization

Thanks, applied with some cleanup and fixes (compiler warnings and crash
on certain invalid Set property value).

PS.

This type of hwsim test cases are quite valuable and appreciated for all
new D-Bus changes:
https://w1.fi/cgit/hostap/commit/?id=cf28cfc12e064bf83d68826545b61a2621f38373