diff mbox

[1/2] Add new Tok-Pisin locales.

Message ID s9dbmozm9td.fsf@redhat.com
State New
Headers show

Commit Message

Mike FABIAN July 5, 2017, 10:56 a.m. UTC
Mike FABIAN <mfabian@redhat.com> wrote:

> Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>
>> [BZ #21694]
>> Added tok-pisin language locale for Papua New Guinea.
>>

According to my comments in my previous mail, I suggest to
add the attached patch to your patch.

Comments

Akhilesh Kumar July 5, 2017, 12:07 p.m. UTC | #1
>> Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>>
>>> [BZ #21694]
>>> Added tok-pisin language locale for Papua New Guinea.
>>>
> 
> According to my comments in my previous mail, I suggest to
> add the attached patch to your patch.

Hi Mike 

Thanks for review comments 

all comments are integared and changes resent for review 

https://sourceware.org/ml/libc-alpha/2017-07/msg00140.html


Additional changes to fix compilation issues 
-% %n%s%z%C
+% %a%s%z%C

# localedef --no-archive -i tpi_PG --charmap=UTF-8 /usr/lib/locale/tpi_PG.utf8
LC_ADDRESS: invalid escape `%n' sequence in field `postal_fmt'
no output file produced because warnings were issued
Chris Leonard July 6, 2017, 4:12 a.m. UTC | #2
On Wed, Jul 5, 2017 at 8:07 AM, AKHILESH KUMAR <akhilesh.k@samsung.com> wrote:
>
>>> Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>>>
>>>> [BZ #21694]
>>>> Added tok-pisin language locale for Papua New Guinea.
>>>>
>>
>> According to my comments in my previous mail, I suggest to
>> add the attached patch to your patch.
>
> Hi Mike
>
> Thanks for review comments
>
> all comments are integared and changes resent for review
>
> https://sourceware.org/ml/libc-alpha/2017-07/msg00140.html
>
>
> Additional changes to fix compilation issues
> -% %n%s%z%C
> +% %a%s%z%C
>
> # localedef --no-archive -i tpi_PG --charmap=UTF-8 /usr/lib/locale/tpi_PG.utf8
> LC_ADDRESS: invalid escape `%n' sequence in field `postal_fmt'
> no output file produced because warnings were issued

Dear friends of Oceania from Samsung,

I'm a big fan of getting new languages into glibc, but we need to take
some care to get it right, especially when it is being done by people
who may not be native speakers (or directly collaborating with native
speakers).

For instance, this Tok Pisin locale does not properly establish the
sort order of the 4 digraphs used by Tok Pisin.

https://en.wikipedia.org/wiki/Tok_Pisin#Alphabet

The Māori (Te Reo) locale provides an excellent example to be followed
for sorting digraphs properly.  Note, there are only two in the Māori
(Te Reo) alpbabet.

https://sourceware.org/git/?p=glibc.git;a=blob;f=localedata/locales/mi_NZ

Looking forward to the improvements to this new locale.

cjl
Carlos O'Donell July 6, 2017, 1:55 p.m. UTC | #3
On 07/06/2017 12:12 AM, Chris Leonard wrote:
> On Wed, Jul 5, 2017 at 8:07 AM, AKHILESH KUMAR <akhilesh.k@samsung.com> wrote:
>>
>>>> Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>>>>
>>>>> [BZ #21694]
>>>>> Added tok-pisin language locale for Papua New Guinea.
>>>>>
>>>
>>> According to my comments in my previous mail, I suggest to
>>> add the attached patch to your patch.
>>
>> Hi Mike
>>
>> Thanks for review comments
>>
>> all comments are integared and changes resent for review
>>
>> https://sourceware.org/ml/libc-alpha/2017-07/msg00140.html
>>
>>
>> Additional changes to fix compilation issues
>> -% %n%s%z%C
>> +% %a%s%z%C
>>
>> # localedef --no-archive -i tpi_PG --charmap=UTF-8 /usr/lib/locale/tpi_PG.utf8
>> LC_ADDRESS: invalid escape `%n' sequence in field `postal_fmt'
>> no output file produced because warnings were issued
> 
> Dear friends of Oceania from Samsung,
> 
> I'm a big fan of getting new languages into glibc, but we need to take
> some care to get it right, especially when it is being done by people
> who may not be native speakers (or directly collaborating with native
> speakers).
> 
> For instance, this Tok Pisin locale does not properly establish the
> sort order of the 4 digraphs used by Tok Pisin.
> 
> https://en.wikipedia.org/wiki/Tok_Pisin#Alphabet
> 
> The Māori (Te Reo) locale provides an excellent example to be followed
> for sorting digraphs properly.  Note, there are only two in the Māori
> (Te Reo) alpbabet.
> 
> https://sourceware.org/git/?p=glibc.git;a=blob;f=localedata/locales/mi_NZ
> 
> Looking forward to the improvements to this new locale.

If there are defects in the glibc locale we should file bugs for the defects
such that we can track the required fixes.
diff mbox

Patch

From 1846a93dd58ff952ac0bbdbf4ca23aefd450bc54 Mon Sep 17 00:00:00 2001
From: Mike FABIAN <mfabian@redhat.com>
Date: Wed, 5 Jul 2017 10:35:32 +0200
Subject: [PATCH 1/3] tpi_PG: Fix whitespace and punctuation; Fix month names
 according to http://www.tok-pisin.com/; yesstr and nostr in lowercase; fix
 typo in country name; fix telephone number format.

---
 localedata/locales/tpi_PG | 60 +++++++++++++++++++++++------------------------
 1 file changed, 30 insertions(+), 30 deletions(-)

diff --git a/localedata/locales/tpi_PG b/localedata/locales/tpi_PG
index 10d32d337a..3a1874b884 100644
--- a/localedata/locales/tpi_PG
+++ b/localedata/locales/tpi_PG
@@ -3,7 +3,7 @@  escape_char /
 
 % tok-pisin language locale for Papua New Guinea.
 % Contributed by Akhilesh Kumar <akhilesh.k@samsung.com>.
-% Wrods translated from  http://www.tok-pisin.com/
+% Words translated from  http://www.tok-pisin.com/
 
 LC_IDENTIFICATION
 title       "tok-pisin language locale for Papua New Guinea"
@@ -11,9 +11,9 @@  source      "Samsung Electronics Co., Ltd."
 address     ""
 contact     ""
 email       "akhilesh.k@samsung.com"
-tel     	""
-fax     	""
-language    "tok-pisin"
+tel         ""
+fax         ""
+language    "Tok Pisin"
 territory   "Papua New Guinea"
 revision    "0.1"
 date        "2017-03-21"
@@ -42,42 +42,44 @@  END LC_CTYPE
 
 LC_COLLATE
 % Copy the template from ISO/IEC 3166
-copy "iso14651_t1" 
+copy "iso14651_t1"
 END LC_COLLATE
 
 LC_TIME
+% Month names from  http://www.tok-pisin.com, the month names from
+% http://wikitravel.org/en/Tok_Pisin_phrasebook differ a bit.
 % Full month names
-% Jenueri, Februeri, Mars, Epril, Mei, Jun, Julai , Ogas , Septemba, Oktoba,  Novemba,Disemba 
-mon	"<U004A><U0065><U006E><U0075><U0065><U0072><U0069>";/
+% Janueri, Februeri, Mas, Epril, Me, Jun, Julai, Ogas, Septemba, Oktoba, Novemba, Desemba
+mon	"<U004A><U0061><U006E><U0075><U0065><U0072><U0069>";/
 	"<U0046><U0065><U0062><U0072><U0075><U0065><U0072><U0069>"
-	"<U004D><U0061><U0072><U0073>";/
+	"<U004D><U0061><U0073>";/
 	"<U0045><U0070><U0072><U0069><U006C>";/
-	"<U004D><U0065><U0069>";/
+	"<U004D><U0065>";/
 	"<U004A><U0075><U006E>";/
 	"<U004A><U0075><U006C><U0061><U0069>";/
 	"<U004F><U0067><U0061><U0073>";/
 	"<U0053><U0065><U0070><U0074><U0065><U006D><U0062><U0061>";/
 	"<U004F><U006B><U0074><U006F><U0062><U0061>";/
 	"<U004E><U006F><U0076><U0065><U006D><U0062><U0061>";/
-	"<U0044><U0069><U0073><U0065><U006D><U0062><U0061>"
+	"<U0044><U0065><U0073><U0065><U006D><U0062><U0061>"
 %
 % Abbreviated month names
-% Jen, Feb, Mar, Epr, Mei, Jun, Jul, Ogs, Sep, Okt, Nov, Dis
+% Jan, Feb, Mar, Epr, Me, Jun, Jul, Oga, Sep, Okt, Nov, Des
 abmon	"<U004A><U0065><U006E>";/
 	"<U0046><U0065><U0062>";/
 	"<U004D><U0061><U0072>";/
 	"<U0045><U0070><U0072>";/
-	"<U004D><U0065><U0069>";/
+	"<U004D><U0065>";/
 	"<U004A><U0075><U006E>";/
 	"<U004A><U0075><U006C>";/
-	"<U004F><U0067><U0073>";/
+	"<U004F><U0067><U0061>";/
 	"<U0053><U0065><U0070>";/
 	"<U004F><U006B><U0074>";/
 	"<U004E><U006F><U0076>";/
-	"<U0044><U0069><U0073>"
+	"<U0044><U0065><U0073>"
 %
 % Full Weekday names
-% Sande, Mande, Tunde, Trinde, Fonde ,Fraide,Sarere
+% Sande, Mande, Tunde, Trinde, Fonde, Fraide, Sarere
 day	"<U0053><U0061><U006E><U0064><U0065>";/
 	"<U004D><U0061><U006E><U0064><U0065>";/
 	"<U0054><U0075><U006E><U0064><U0065>";/
@@ -110,7 +112,7 @@  d_fmt	"<U0025><U0064><U002F><U0025><U006D><U002F><U0025><U0059>"
 t_fmt	"<U0025><U0072>"
 %
 % Equivalent of AM PM
-% AM ->biknait PM->apinun 
+% AM -> biknait PM -> apinun (from http://wikitravel.org/en/Tok_Pisin_phrasebook)
 %
 am_pm	"<U0062><U0069><U006B><U006E><U0061><U0069><U0074>";/
 	"<U0061><U0070><U0069><U006E><U0075><U006E>"
@@ -128,13 +130,12 @@  thousands_sep "<U002C>"
 grouping      3
 END LC_NUMERIC
 %
-% https://en.wikipedia.org/wiki/Papua_New_Guinea 
+% https://en.wikipedia.org/wiki/Papua_New_Guinea
 % PGK
 % https://en.wikipedia.org/wiki/Papua_New_Guinean_kina
 % https://en.wikipedia.org/wiki/Currency_symbol
 % K
 LC_MONETARY
-% fix me
 currency_symbol		"<U004B>"
 int_curr_symbol		"<U0050><U0047><U004B><U0020>"
 mon_decimal_point	"<U002E>"
@@ -149,13 +150,12 @@  int_p_sep_by_space	1
 p_sep_by_space		1
 n_cs_precedes		1
 int_n_sep_by_space	1
-n_sep_by_space		1	
+n_sep_by_space		1
 p_sign_posn			1
 n_sign_posn			1
 END LC_MONETARY
 
 LC_PAPER
-% fix me
 copy "i18n"
 END LC_PAPER
 
@@ -170,7 +170,7 @@  yesexpr "<U005E><U005B><U0079><U0059><U005D><U002E><U002A>"
 noexpr  "<U005E><U005B><U006E><U004E><U005D><U002E><U002A>"
 % yes
 yesstr "<U0079><U0065><U0073>"
-% Nogat
+% nogat
 nostr "<U004E><U006F><U0067><U0061><U0074>"
 END LC_MESSAGES
 
@@ -184,8 +184,8 @@  LC_ADDRESS
 % %n%s%z%C
 postal_fmt    "<U0025><U006E><U0025><U0073><U0025><U007A><U0025><U0043>"
 % Papua New Guinea
-country_name "<U0050><U0061><U0070>U0075><U0061><U0020><U004E><U0065><U0077><U0020><U0047><U0075><U0069><U006E><U0065><U0061>"
-% No code 
+country_name "<U0050><U0061><U0070><U0075><U0061><U0020><U004E><U0065><U0077><U0020><U0047><U0075><U0069><U006E><U0065><U0061>"
+% No code
 country_post ""
 % http://laendercode.net/en/2-letter-list.html
 % PG
@@ -194,25 +194,25 @@  country_ab2  "<U0050><U0047>"
 % http://laendercode.net/en/countries.html
 country_ab3  "<U0050><U004E><U0047>"
 country_car  "<U0050><U004E><U0047>"
+% https://en.wikipedia.org/wiki/ISO_3166-1_numeric
 country_num 598
-% http://www.nationsonline.org/oneworld/international-calling-codes.htm
-% Fix Me 
-% country_num 675 
 % Tok Pisin
 lang_name    "<U0054><U006F><U006B><U0020><U0050><U0069><U0073><U0069><U006E>"
 % https://en.wikipedia.org/wiki/Tok_Pisin
-% lang_ab      "<U0074><U0070>"
-% tpi
+% "", "tpi", "tpi"
+lang_ab      ""
 lang_term    "<U0074><U0070><U0069>"
 lang_lib     "<U0074><U0070><U0069>"
 END LC_ADDRESS
 
 LC_TELEPHONE
 % https://www.howtocallabroad.com/papua/
-% +%c ;%l
-tel_int_fmt "<U002B><U0025><U0063><U0020><U003B><U0025><U0061><U0020><U003B><U0025><U006C>"
+% https://en.wikipedia.org/wiki/Telephone_numbers_in_Papua_New_Guinea
+% +%c %l
+tel_int_fmt "<U002B><U0025><U0063><U0020><U0025><U006C>"
 % 00
 int_select  "<U0030><U0030>"
+% http://www.nationsonline.org/oneworld/international-calling-codes.htm
 % 675
 int_prefix  "<U0036><U0037><U0035>"
 END LC_TELEPHONE
-- 
2.13.0