From patchwork Thu Dec 18 05:44:10 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Oliva X-Patchwork-Id: 422479 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 69DE2140079 for ; Thu, 18 Dec 2014 16:44:33 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=nR3rr il98JC3iKy1iKKklWz+tQEXAPKl+oFkZc0F50rnOKQaAXZlt0T0AaHElg2kpAN2o G/jxDAosjxvKwVzgt1hnO9ZAOotPZn4UZwNIiXGz8PbuDAhELXGGbL+1HV8xW9PE 3bYICoK3QwTpeErjCPB+JPbWeInUOpi9XozT+E= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=55+Ae2gPFxP CyBGpuRD3F6qIaqA=; b=Rqg3aXYWOMIs+pI+N0q0BE1H+N2q2eLWZqa0KzjQipv qWbYEVQXKIGw/KoP7YrFdIv9arGXhDJbBehuJzzM/GXiShvatZaRAowXGWC436W9 /2CCbEp74kl9+BXbrRgieME9oZwaiIn8GdmeJCEO/5BBBOTFkcmqekCjgy7aFyos = Received: (qmail 18485 invoked by alias); 18 Dec 2014 05:44:28 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 18472 invoked by uid 89); 18 Dec 2014 05:44:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com From: Alexandre Oliva To: MaShimiao Cc: libc-alpha@sourceware.org Subject: Re: question about env and function malloc References: <54744550.80909@cn.fujitsu.com> <5487B38B.8000804@cn.fujitsu.com> <548E888F.9090007@cn.fujitsu.com> <5490E3CA.9000301@cn.fujitsu.com> Date: Thu, 18 Dec 2014 03:44:10 -0200 In-Reply-To: <5490E3CA.9000301@cn.fujitsu.com> (MaShimiao's message of "Wed, 17 Dec 2014 10:00:42 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 [Cc:ing the list] On Dec 17, 2014, MaShimiao wrote: > But, the description of env in glibc manual says if a function accesses > environment with getenv() of similar, without any guard, then it should be > marked with env. it doesn't mention any special functions. > Do you think we should add some words to remind users that there are some special > conditions in which even a function calls getenv(), it will not be marked with env. > Just like malloc() or free(). > Or we just add explanations in the description of each special functions? I think a note at the exception point should be enough, as in the patch below. Ok to install? for ChangeLog * manual/memory.texi (malloc): Elaborate rationale to drop @mtsenv from malloc_printerr. --- manual/memory.texi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/manual/memory.texi b/manual/memory.texi index 0729e70..03242c3 100644 --- a/manual/memory.texi +++ b/manual/memory.texi @@ -376,9 +376,9 @@ this function is in @file{stdlib.h}. @c fastbin_index ok @c fastbin ok @c catomic_compare_and_exhange_val_acq ok -@c malloc_printerr dup @mtsenv -@c if we get to it, we're toast already, undefined behavior must have -@c been invoked before +@c malloc_printerr dup ok [no @mtsenv, see below] +@c if we get to malloc_printerr, undefined behavior must have been +@c invoked, so don't bother propagating @mtsenv up the call chain @c libc_message @mtsenv [no leaks with cancellation disabled] @c FATAL_PREPARE ok @c pthread_setcancelstate disable ok