From patchwork Wed Apr 16 09:24:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stefan Liebler X-Patchwork-Id: 339477 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id C01F814009F for ; Wed, 16 Apr 2014 19:24:36 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:from:subject:date:message-id:references :mime-version:content-type:in-reply-to; q=dns; s=default; b=dnon +QYmhDnzo7WuQMPiNFRL4OYw5BiwLL7Vv5iWfM9PFB/wo3iyv73KQtBKXCL9g+b8 StRyKcRIRqn/WWP6CkmLsMFihW2pire4IQgWYVYawsn4qKNJtMfn608ykkgguc9z ybDVDxNT9vzUy4vrkoYTt6cgVRW+de2Cots8b+A= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:from:subject:date:message-id:references :mime-version:content-type:in-reply-to; s=default; bh=qLHQHIQG8b PNNcSoBDjV0YIhxWY=; b=v9LXKTcskADxo9mvKyBy4JhKPO9viX5ibFWoxTSw2E 0XjxRmx3Zbh8WqfNNP96aSrdzs80QE1gp6nifT05XzUi14PY2Qu3FqR1ABtWmbhp 8VSAFIMjOgtHIxABUj10Ha0mg6w+l9e0mVL3nkQwdfQG5o3NlewQOjncdDF7uocm E= Received: (qmail 17046 invoked by alias); 16 Apr 2014 09:24:30 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 17034 invoked by uid 89); 16 Apr 2014 09:24:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-HELO: plane.gmane.org To: libc-alpha@sourceware.org From: Stefan Liebler Subject: Re: [PATCH] Do not run timezone tests in parallel. Date: Wed, 16 Apr 2014 11:24:08 +0200 Lines: 55 Message-ID: References: Mime-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 In-Reply-To: Thanks. You´re right. I missed the fact that it´s a pattern rule and thought it is a normal multiple target. The comment is relevant. ok? Bye. On 04/15/2014 05:14 PM, Andreas Schwab wrote: > Stefan Liebler writes: > >> @@ -102,7 +105,6 @@ $(testdata)/America/New_York: northamerica $(zic-deps) >> $(build-testdata) >> $(testdata)/Etc/UTC: etcetera $(zic-deps) >> $(build-testdata) >> -# Use a pattern rule to indicate the command produces both targets at once. >> # Two separate targets built separately can collide if in parallel. >> %/UTC %/Universal: simplebackw $(zic-deps) %/Etc/UTC >> $(build-testdata) > > Why is that comment no longer relevant? > > Andreas. > diff --git a/timezone/Makefile b/timezone/Makefile index 998cd14..decc28e 100644 --- a/timezone/Makefile +++ b/timezone/Makefile @@ -85,6 +85,9 @@ GCONV_PATH=${common-objpfx}iconvdata LANGUAGE=C LC_ALL=C \ $(evaluate-test) endef + +.NOTPARALLEL: + $(objpfx)test-tz.out: $(addprefix $(testdata)/, America/New_York Etc/UTC UTC) $(objpfx)tst-timezone.out: $(addprefix $(testdata)/, \ Europe/Berlin Universal \