Message ID | b26c6dd7-1245-42ee-7651-9aa4c8ae88de@linux.ibm.com |
---|---|
State | New |
Headers | show |
Series | Add missing libnss_testX.so requirement for tst-nss-test3. | expand |
On 12/12/18 6:48 AM, Stefan Liebler wrote: > Hi, > > Sometimes tst-nss-test3 fails with: > error: test-container.c:386: unable to open .../nss/libnss_test1.so for reading > > The test tst-nss-test3 which runs in a container needs > libnss_test[12].so. (see e.g. tst-nss-test3.script). > Before this test was moved from tests to tests-container variable, > the requirement was met. Thus this patch adds this requirement > also for tests in tests-container. > > Okay to commit? > > Bye, > Stefan > > ChangeLog: > > * nss/Makefile (tst-nss-test3.out): New rule. OK for master. Reviewed-by: Carlos O'Donell <carlos@redaht.com>
On 12/12/2018 03:34 PM, Carlos O'Donell wrote: > On 12/12/18 6:48 AM, Stefan Liebler wrote: >> Hi, >> >> Sometimes tst-nss-test3 fails with: >> error: test-container.c:386: unable to open .../nss/libnss_test1.so for reading >> >> The test tst-nss-test3 which runs in a container needs >> libnss_test[12].so. (see e.g. tst-nss-test3.script). >> Before this test was moved from tests to tests-container variable, >> the requirement was met. Thus this patch adds this requirement >> also for tests in tests-container. >> >> Okay to commit? >> >> Bye, >> Stefan >> >> ChangeLog: >> >> * nss/Makefile (tst-nss-test3.out): New rule. > > OK for master. > > Reviewed-by: Carlos O'Donell <carlos@redaht.com> > Thanks. Committed.
commit aa415088f0a8be316b315bfd114487cc6466f1f1 Author: Stefan Liebler <stli@linux.ibm.com> Date: Wed Dec 12 12:44:06 2018 +0100 Add missing libnss_testX.so requirement for tst-nss-test3. Sometimes tst-nss-test3 fails with: error: test-container.c:386: unable to open .../nss/libnss_test1.so for reading The test tst-nss-test3 which runs in a container needs libnss_test[12].so. (see e.g. tst-nss-test3.script). Before this test was moved from tests to tests-container variable, the requirement was met. Thus this patch adds this requirement also for tests in tests-container. ChangeLog: * nss/Makefile (tst-nss-test3.out): New rule. diff --git a/nss/Makefile b/nss/Makefile index e00a4f7..c5f1a7d 100644 --- a/nss/Makefile +++ b/nss/Makefile @@ -163,7 +163,7 @@ ifdef libnss_test2.so-version $(objpfx)/libnss_test2.so$(libnss_test2.so-version): $(objpfx)/libnss_test2.so $(make-link) endif -$(patsubst %,$(objpfx)%.out,$(tests)) : \ +$(patsubst %,$(objpfx)%.out,$(tests) $(tests-container)) : \ $(objpfx)/libnss_test1.so$(libnss_test1.so-version) \ $(objpfx)/libnss_test2.so$(libnss_test2.so-version)