| Message ID | alpine.DEB.2.20.1701032137130.14638@digraph.polyomino.org.uk |
|---|---|
| State | New |
| Headers | show |
LGTM, this the same fix I used locally. > On 3 Jan 2017, at 19:37, Joseph Myers <joseph@codesourcery.com> wrote: > > Many linknamespace tests fail for MicroBlaze because __backtrace (as > brought in by libc_fatal.c) uses an inline function get_frame_size > which is not declared static. This patch fixes it to be declared > static. > > Tested (compilation tests) with build-many-glibcs.py. > > 2017-01-03 Joseph Myers <joseph@codesourcery.com> > > [BZ #21022] > * sysdeps/microblaze/backtrace.c (get_frame_size): Make static. > > diff --git a/sysdeps/microblaze/backtrace.c b/sysdeps/microblaze/backtrace.c > index 2b498f0..7cc28ff 100644 > --- a/sysdeps/microblaze/backtrace.c > +++ b/sysdeps/microblaze/backtrace.c > @@ -27,7 +27,7 @@ _identify_sighandler (unsigned long fp, unsigned long pc, > unsigned long *pprev_fp, unsigned long *pprev_pc, > unsigned long *retaddr); > > -inline long > +static inline long > get_frame_size (unsigned long instr) > { > return abs ((short signed) (instr & 0xFFFF)); > > -- > Joseph S. Myers > joseph@codesourcery.com
On 01/03/2017 01:37 PM, Joseph Myers wrote: > Many linknamespace tests fail for MicroBlaze because __backtrace (as > brought in by libc_fatal.c) uses an inline function get_frame_size > which is not declared static. This patch fixes it to be declared > static. > > Tested (compilation tests) with build-many-glibcs.py. > > 2017-01-03 Joseph Myers <joseph@codesourcery.com> > > [BZ #21022] > * sysdeps/microblaze/backtrace.c (get_frame_size): Make static. > > diff --git a/sysdeps/microblaze/backtrace.c b/sysdeps/microblaze/backtrace.c > index 2b498f0..7cc28ff 100644 > --- a/sysdeps/microblaze/backtrace.c > +++ b/sysdeps/microblaze/backtrace.c > @@ -27,7 +27,7 @@ _identify_sighandler (unsigned long fp, unsigned long pc, > unsigned long *pprev_fp, unsigned long *pprev_pc, > unsigned long *retaddr); > > -inline long > +static inline long > get_frame_size (unsigned long instr) > { > return abs ((short signed) (instr & 0xFFFF)); OK.
diff --git a/sysdeps/microblaze/backtrace.c b/sysdeps/microblaze/backtrace.c index 2b498f0..7cc28ff 100644 --- a/sysdeps/microblaze/backtrace.c +++ b/sysdeps/microblaze/backtrace.c @@ -27,7 +27,7 @@ _identify_sighandler (unsigned long fp, unsigned long pc, unsigned long *pprev_fp, unsigned long *pprev_pc, unsigned long *retaddr); -inline long +static inline long get_frame_size (unsigned long instr) { return abs ((short signed) (instr & 0xFFFF));