From patchwork Mon Oct 26 23:33:08 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joseph Myers X-Patchwork-Id: 536376 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 60DFD14132F for ; Tue, 27 Oct 2015 10:33:25 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b=mWDZwKks; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:message-id:mime-version :content-type; q=dns; s=default; b=dLOi9omr+WBN/RZ+7qlXWoeORMP6p wITiJk38UfpEdETKBZqyXDcT227atCR++CVaDByMiVd8LbY73xSjijeeJLKXHOaK eQ+jzEv0HBR0E3Oohj0m+gqMLYnU8OfFBhI1HTu+ZerykdmEZiQ9egkeYBjlbMXy CUobXlhme9y3bM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:message-id:mime-version :content-type; s=default; bh=Wno8ImDsi3JpQPTv12d7Fjpnj2M=; b=mWD ZwKksQVAONbwoSUw43ehqn+dxvi9jNvt0DZ/yOzhJdT0bFbTaXO3T0ys3fqLpt0L E4TN15Nh6R7W4VJnx5E80rETdXW1akJZkBWmDNXL1Y0zFujBJSFrPnkTR9aQ38pv BLE9vAuzMFCgVPNfinRllIxy+7UnmOzt3vtNrijs= Received: (qmail 58166 invoked by alias); 26 Oct 2015 23:33:16 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 58154 invoked by uid 89); 26 Oct 2015 23:33:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.7 required=5.0 tests=AWL, BAYES_50, RCVD_IN_DNSWL_LOW, SPF_PASS, URIBL_BLACK, URIBL_JP_SURBL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Date: Mon, 26 Oct 2015 23:33:08 +0000 From: Joseph Myers To: Subject: Remove TLS configure tests Message-ID: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 There seemed to be support in response to for removing configure tests that exist only to produce errors, where we expect that tool versions failing the tests would also fail the tests of minimum GCC / binutils versions. This patch removes the tests for TLS support as one instance of such tests. Since the addition of TLS emulation support in GCC 4.3, I don't think these tests would have failed even if proper TLS support (as required by glibc) was missing in that architecture's GCC back end, so any new glibc ports wanting a substantive test (if there are actual GCC or binutils versions for those architectures, with supported version numbers, missing TLS support) would have needed an architecture-specific test anyway. Tested for x86_64 and x86 (testsuite, and that installed shared libraries are unchanged by the patch). 2015-10-26 Joseph Myers * configure.ac (libc_cv_gcc___thread): Remove configure test. (libc_cv_gcc_tls_model_attr): Likewise. * configure: Regenerated. diff --git a/configure b/configure index 22aa1b9..ac09f40 100755 --- a/configure +++ b/configure @@ -6170,58 +6170,6 @@ if test "$libc_cv_gcc_builtin_redirection" = no; then as_fn_error $? "support for the symbol redirection needed" "$LINENO" 5 fi -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for __thread" >&5 -$as_echo_n "checking for __thread... " >&6; } -if ${libc_cv_gcc___thread+:} false; then : - $as_echo_n "(cached) " >&6 -else - cat > conftest.c <<\EOF -__thread int a = 42; -EOF -if { ac_try='${CC-cc} $CFLAGS $CPPFLAGS -c conftest.c >&5' - { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 - (eval $ac_try) 2>&5 - ac_status=$? - $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5 - test $ac_status = 0; }; }; then - libc_cv_gcc___thread=yes -else - libc_cv_gcc___thread=no -fi -rm -f conftest* -fi -{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_gcc___thread" >&5 -$as_echo "$libc_cv_gcc___thread" >&6; } -if test "$libc_cv_gcc___thread" = no; then - as_fn_error $? "support for the __thread keyword is required" "$LINENO" 5 -fi - -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for tls_model attribute" >&5 -$as_echo_n "checking for tls_model attribute... " >&6; } -if ${libc_cv_gcc_tls_model_attr+:} false; then : - $as_echo_n "(cached) " >&6 -else - cat > conftest.c <<\EOF -extern __thread int a __attribute__((tls_model ("initial-exec"))); -EOF -if { ac_try='${CC-cc} $CFLAGS $CPPFLAGS -S -Werror conftest.c >&5' - { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 - (eval $ac_try) 2>&5 - ac_status=$? - $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5 - test $ac_status = 0; }; }; then - libc_cv_gcc_tls_model_attr=yes -else - libc_cv_gcc_tls_model_attr=no -fi -rm -f conftest* -fi -{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_gcc_tls_model_attr" >&5 -$as_echo "$libc_cv_gcc_tls_model_attr" >&6; } -if test "$libc_cv_gcc_tls_model_attr" = no; then - as_fn_error $? "support for the tls_model attribute is required" "$LINENO" 5 -fi - { $as_echo "$as_me:${as_lineno-$LINENO}: checking for compiler option to disable generation of FMA instructions" >&5 $as_echo_n "checking for compiler option to disable generation of FMA instructions... " >&6; } if ${libc_cv_cc_nofma+:} false; then : diff --git a/configure.ac b/configure.ac index 6947555..4d6852e 100644 --- a/configure.ac +++ b/configure.ac @@ -1581,36 +1581,6 @@ if test "$libc_cv_gcc_builtin_redirection" = no; then AC_MSG_ERROR([support for the symbol redirection needed]) fi -dnl Check whether the compiler supports the __thread keyword. -AC_CACHE_CHECK([for __thread], libc_cv_gcc___thread, -[cat > conftest.c <<\EOF -__thread int a = 42; -EOF -if AC_TRY_COMMAND([${CC-cc} $CFLAGS $CPPFLAGS -c conftest.c >&AS_MESSAGE_LOG_FD]); then - libc_cv_gcc___thread=yes -else - libc_cv_gcc___thread=no -fi -rm -f conftest*]) -if test "$libc_cv_gcc___thread" = no; then - AC_MSG_ERROR([support for the __thread keyword is required]) -fi - -dnl Check whether the compiler supports the tls_model attribute. -AC_CACHE_CHECK([for tls_model attribute], libc_cv_gcc_tls_model_attr, [dnl -cat > conftest.c <<\EOF -extern __thread int a __attribute__((tls_model ("initial-exec"))); -EOF -if AC_TRY_COMMAND([${CC-cc} $CFLAGS $CPPFLAGS -S -Werror conftest.c >&AS_MESSAGE_LOG_FD]); then - libc_cv_gcc_tls_model_attr=yes -else - libc_cv_gcc_tls_model_attr=no -fi -rm -f conftest*]) -if test "$libc_cv_gcc_tls_model_attr" = no; then - AC_MSG_ERROR([support for the tls_model attribute is required]) -fi - dnl Determine how to disable generation of FMA instructions. AC_CACHE_CHECK([for compiler option to disable generation of FMA instructions], libc_cv_cc_nofma, [dnl