From patchwork Mon Jun 23 00:54:56 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Maciej W. Rozycki" X-Patchwork-Id: 362626 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id DB3BF140084 for ; Mon, 23 Jun 2014 10:55:13 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:message-id:mime-version :content-type; q=dns; s=default; b=OvYlDxRFAEUm/0v42IjgknMlA1vwh 2+ZscEvfghKVAf17HssaIyP8FIg7hiZsBOnahPPt3P9X3n5Mqmme6r1ONtdTvIyA lH2NjESXBAX62BiKMlKeQqhyAhBvw2zUy1UBJF3XX6E7j2cjOlztiZzgcf3OsNlL ampCcU9SWSqBYo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:message-id:mime-version :content-type; s=default; bh=4spLaGiSflVBWaxEZB32lSmhB4M=; b=ZLH t4zr37dWEXeO2XNmiV1EPa6ZDD5HK4kZDs4Loxok2Tu90YbPBImIg0o1b4r3Yds9 OgVu8A//2ytknMMxvRdd855RsbedEQm820269bHdEmzvldg9ANoukw980o+XepID QwOckVcYWgw2TJuT5mLUFrSEg63zbg2diwh1Mpx0= Received: (qmail 32428 invoked by alias); 23 Jun 2014 00:55:07 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 32416 invoked by uid 89); 23 Jun 2014 00:55:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Date: Mon, 23 Jun 2014 01:54:56 +0100 From: "Maciej W. Rozycki" To: Subject: [PATCH] stdlib/tst-strtod-overflow: Bump timeout up yet more Message-ID: User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Hi, In our routine testing I observed that stdlib/tst-strtod-overflow is very slow, especially on targets using soft-float or QEMU (where soft-float is used internally), enough to time out even on slow boards we have that have TIMEOUTFACTOR already bumped from the default of 1 up to 75. No other test case requires such a long timeout -- all the other succeeding cases fit within their timeouts scaled by TIMEOUTFACTOR on these boards. As such I think it's counter-productive to require TIMEOUTFACTOR to be set as high as 450 globally for this lone outlier as the value affects overall testing duration where there are test cases that genuinely time out due to a defect. Therefore I propose the following change that makes stdlib/tst-strtod-overflow pass on these slow boards with TIMEOUTFACTOR of 75. OK to apply? 2014-06-23 Maciej W. Rozycki * stdlib/tst-strtod-overflow.c (TIMEOUT): Bump up to 30. Maciej Index: glibc-fsf-trunk-quilt/stdlib/tst-strtod-overflow.c =================================================================== --- glibc-fsf-trunk-quilt.orig/stdlib/tst-strtod-overflow.c 2014-06-17 15:50:29.991694082 +0100 +++ glibc-fsf-trunk-quilt/stdlib/tst-strtod-overflow.c 2014-06-23 01:49:28.082011090 +0100 @@ -45,5 +45,5 @@ do_test (void) } #define TEST_FUNCTION do_test () -#define TIMEOUT 5 +#define TIMEOUT 30 #include "../test-skeleton.c"