diff mbox series

[06/18] Legacy unwinder: Remove definition of _Unwind_GetCFA

Message ID a9cf0f9308a3217f32aa4196f1b5d3c29378602a.1615569355.git.fweimer@redhat.com
State New
Headers show
Series Repost of pending libpthread removal patches | expand

Commit Message

Florian Weimer March 12, 2021, 5:49 p.m. UTC
It is not actually used by the legacy unwinder linked into
libc.so, and it conflicts with the unwind-link functionality
in libpthread.
---
 sysdeps/generic/unwind-dw2.c | 8 --------
 1 file changed, 8 deletions(-)

Comments

Adhemerval Zanella March 16, 2021, 2:14 p.m. UTC | #1
On 12/03/2021 14:49, Florian Weimer via Libc-alpha wrote:
> It is not actually used by the legacy unwinder linked into
> libc.so, and it conflicts with the unwind-link functionality
> in libpthread.

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> ---
>  sysdeps/generic/unwind-dw2.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/sysdeps/generic/unwind-dw2.c b/sysdeps/generic/unwind-dw2.c
> index 618fa8885f..da971279be 100644
> --- a/sysdeps/generic/unwind-dw2.c
> +++ b/sysdeps/generic/unwind-dw2.c
> @@ -177,14 +177,6 @@ _Unwind_GetGR (struct _Unwind_Context *context, int index)
>    return * (_Unwind_Word *) context->reg[index];
>  }
>  
> -/* Get the value of the CFA as saved in CONTEXT.  */
> -
> -_Unwind_Word
> -_Unwind_GetCFA (struct _Unwind_Context *context)
> -{
> -  return (_Unwind_Ptr) context->cfa;
> -}
> -
>  /* Overwrite the saved value for register REG in CONTEXT with VAL.  */
>  
>  inline void
>
diff mbox series

Patch

diff --git a/sysdeps/generic/unwind-dw2.c b/sysdeps/generic/unwind-dw2.c
index 618fa8885f..da971279be 100644
--- a/sysdeps/generic/unwind-dw2.c
+++ b/sysdeps/generic/unwind-dw2.c
@@ -177,14 +177,6 @@  _Unwind_GetGR (struct _Unwind_Context *context, int index)
   return * (_Unwind_Word *) context->reg[index];
 }
 
-/* Get the value of the CFA as saved in CONTEXT.  */
-
-_Unwind_Word
-_Unwind_GetCFA (struct _Unwind_Context *context)
-{
-  return (_Unwind_Ptr) context->cfa;
-}
-
 /* Overwrite the saved value for register REG in CONTEXT with VAL.  */
 
 inline void