From patchwork Tue Mar 18 00:07:19 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joseph Myers X-Patchwork-Id: 331258 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 7A97C2C00A0 for ; Tue, 18 Mar 2014 11:07:37 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=QKTZY aaZlyqSTuEKTxLUcj+z830DsN/wfwGnuZiy6/BFxGO1mGWdxcvK/rMuN6S3zOXXx mGGffRwmtaJ+mRGkxCajr2X+yjjACvt604vjPV9XqAfWJH9ibSqh1TQs9khJXRyC vmw1K86DBPj6MW6+EsNrDQlCEPYhfeNm1FwC1Q= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=Qkjqd+El0IC J6foKbJUP0S3rfJw=; b=hAdoaQCjgI6WkySm+hZLFxTboOecNgoOCwiOTprcutX QRaoCeTqGhDNsCri+Y5TICZUTYoNz3K9vYFTtSjgRM3nAVzVKBRwz5at5JnAU2QN NqkE6xBJGiaWJxLOYMNhz9Dd0use67DYRI+RS15eP9Vl9dsN8YfFf2Tn9CNqZY2Q = Received: (qmail 24038 invoked by alias); 18 Mar 2014 00:07:31 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 23960 invoked by uid 89); 18 Mar 2014 00:07:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL, BAYES_40 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Date: Tue, 18 Mar 2014 00:07:19 +0000 From: "Joseph S. Myers" To: Roland McGrath CC: "GNU C. Library" Subject: Re: PLEASE FIX NOW! make check-abi exits zero on failure In-Reply-To: <20140317225024.5DDBC74464@topped-with-meat.com> Message-ID: References: <20140317225024.5DDBC74464@topped-with-meat.com> MIME-Version: 1.0 Since you want a quick fix, I've applied this patch. (Really the subdirectory check-abi targets should generate .sum files and then toplevel combine those, just like the tests and xtests targets.) diff --git a/ChangeLog b/ChangeLog index c7e121d..b007a2e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2014-03-18 Joseph Myers + + * Makerules [!subdir] (check-abi): Exit with error status if a + test failed. + 2014-03-17 Joseph Myers * math/libm-test.inc (nearbyint_test_data): Include all tests used diff --git a/Makerules b/Makerules index 008e80a..4427f4e 100644 --- a/Makerules +++ b/Makerules @@ -1257,6 +1257,7 @@ subdir_check-abi: check-abi subdir_update-abi: update-abi else check-abi: subdir_check-abi + if grep -q '^FAIL:' $(objpfx)*/check-abi*.test-result; then exit 1; fi update-abi: subdir_update-abi endif