From patchwork Thu Feb 11 17:21:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Senkevich X-Patchwork-Id: 581982 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 9F5D3140BC4 for ; Fri, 12 Feb 2016 04:21:58 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b=VzPoeggN; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; q=dns; s=default; b=t+qD OcpkUZRrPlZYTOwl2A8uLPoVhyHBEGtv8V32FHGsbZbT+x2HtFLIfe3wmAhh7zjL juwbdNhSjmytLOdO5kmvZ//PmYm7ec7RTreuHVIhNK6ZSaKb+ALzDdMnS/xdtGvC bUeEXrwlV94DN6rSfkDO+W3E3aXX/5owX24lzSg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; s=default; bh=n2wOqCoW7s RwAtSnDGEWjp4Lh6U=; b=VzPoeggN90PYAGLGtFOqZzuSB5epLuTtJfMfgNZjce YmaihWC9Cpq6TcIMjStvDT/AfbwsETjkq62X57zpjTD2Ss2biQbdQgMbxK1cxVgu WznxnhGuQB4oe0aFCkG5kimIBDVG3QjYxQ3w404RGRIJJnPK9CueDZgEaY4Lscn7 E= Received: (qmail 68398 invoked by alias); 11 Feb 2016 17:21:53 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 68383 invoked by uid 89); 11 Feb 2016 17:21:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=238, rajilinuxvnetibmcom, raji@linux.vnet.ibm.com, andrew.senkevich@intel.com X-HELO: mail-lb0-f175.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=lMGo1gCgBTDIiZTN9+i6CUMyB58Rv3D5eh1JEZ+4SvE=; b=GhgOwI+HBiqTVYPAOsGcYA794+CIQP/OZc29QqPTIKfklO+qrl9pAALLXeZQBU54oZ bU9I60IhkVonvuYBbfeCoY9GlJRn9/uc4f+IaJkRMNjCTVryPnND+QQ2QNNryq8yEllE ZtwiH5F5uog8OJ3kSNnK4q+foRDEPu7R5RJgjZOqChNac9pV3OwtBEF4fRoJLvCfIhNW SDFh5jukBymlXHOMegNAMXRbHLYHLrVIG6QUyrEbOwz1eoo14G6IFQ1FQzc6TnH1vtND pu89l+RlSaLAeGxQ5dlUDKzELKSqiyC0YIecQRMb8fRgseikLRDwzKIKpRSVKEYnARs5 3MXw== X-Gm-Message-State: AG10YOQYUR14SlpJR9QnPpvcnzkQW/9rJyGqC+FlS8LbX6LINkveOuu8svDjTgf+qrXFmFGp22NKjEtXD8Yv2A== X-Received: by 10.112.161.225 with SMTP id xv1mr19394331lbb.127.1455211307476; Thu, 11 Feb 2016 09:21:47 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: From: Andrew Senkevich Date: Thu, 11 Feb 2016 20:21:17 +0300 Message-ID: Subject: Re: [PATCH] BZ #19590: Fixed build of shared objects that use libmvec.so functions To: Joseph Myers Cc: "H.J. Lu" , libc-alpha 2016-02-11 19:43 GMT+03:00 Joseph Myers : > On Thu, 11 Feb 2016, Andrew Senkevich wrote: > >> If we need runtime tests with calls to finite aliases it looks better >> to adopt build of existing libmvec tests. We can call finite aliases >> in *-wrappers.c and build shared library from them and link with it >> test binaries. Is this approach looks OK? > > I don't think the finite aliases should be considered part of the API to > test; it's an implementation detail of the header that they may get > referenced in certain circumstances. I agree. > The relevant thing to test is > whether building a program that directly calls the scalar functions, with > options such that the calls get vectorized, works (including with variant > options for e.g. LTO). But it looks more like compiler test, not library. Or do you mean some ABI test for vector functions? In any case is it necessary for this patch or the following patch is Ok for thrunk? --- WBR, Andrew diff --git a/ChangeLog b/ChangeLog index 11c3156..6ebcefb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2016-02-10 Andrew Senkevich + Carlos O'Donell + + [BZ #19590] + * sysdeps/x86_64/fpu/svml_finite_alias.S (ALIAS_IMPL): Use PLT. + 2016-02-04 Rajalakshmi Srinivasaraghavan * sysdeps/powerpc/fpu/libm-test-ulps: Regenerated. diff --git a/sysdeps/x86_64/fpu/svml_finite_alias.S b/sysdeps/x86_64/fpu/svml_finite_alias.S index 0062fe4..8314cf4 100644 --- a/sysdeps/x86_64/fpu/svml_finite_alias.S +++ b/sysdeps/x86_64/fpu/svml_finite_alias.S @@ -23,8 +23,7 @@ #define ALIAS_IMPL(alias, target) \ ENTRY (alias); \ - call target; \ - ret; \ + jmp target@PLT; \ END (alias) .text