From patchwork Mon Nov 24 21:36:27 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sterling Augustine X-Patchwork-Id: 414119 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 19ED9140147 for ; Tue, 25 Nov 2014 08:36:37 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; q=dns; s=default; b= WDd/Ow/Tw6wOIW2O+g1e7xJnB7RMExqrB+sEnNYP2gVn2cexIHXUuxPWH89pAY4C bcMrnRKKnUlTRgiPFM26xL0u0BhCFwa4qK2tgLaplX2xw5oJ1HAsoHBSlzstGZlE gq/9BwloRzs4Jqo4ZlAC1iNM5uIvRzGHwIwIHozbFk4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; s=default; bh=fAoAK HmosguCSlMdiVzdOkDJA58=; b=tmUfe+xACyUdWD89bBrBuLNYVRuf14+d6C57R MymalYyaifRI2IFmlKyeQu9fYa17FlbLja6LcF9NedJ4gAvTmL3NlvilsblEqYUw SVz6lMzgAxY7yOEgIFKtuQX5QmE61wgIYfJc/ztG47rlyyEqkwtrpJcYGymN1ovI JyWAlQ= Received: (qmail 15117 invoked by alias); 24 Nov 2014 21:36:31 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 15106 invoked by uid 89); 24 Nov 2014 21:36:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ob0-f179.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=noxZ6NkXIW1k7Cs4cpmZWAKXLD2ck92uJ2tBO7pI1a8=; b=WAioeDx1x93MgyMciuGBDqxYBf/9AxPc/7RozlvWeqTrIvFk1Ybup1hFnjJwMSXvcF tr4Aa2AyRGwEwBkBm1ewIvCG/wVT/YE1eD6/WggZbNxpMbQQBkRALjfbew0g4K5xmVUY DyZk+aIDptNaBOGWj0PPzAirL04ptWEsWuy3UZtLj5xT/LKieuA/jlIzHxp3gSqQWrwP wKGRyUu+koY+rRy2Gb3CEPXPWk90JC0O7Xjhv+9f1/2MfXYY1WqzwUyxyGju1YS+55nc LZSBnoqtozqrT9d45vB8+7rBfOVNzuyR3oWOh09wBj+E99Cu/gocf5MiKuItWa88zbY1 vvMQ== X-Gm-Message-State: ALoCoQkxVEVbvNRgitts4tJhtXaxqpPjuExNqR/g9EniNeGS41NZFxr7t5DzuxU5e7GQGZvAivXN MIME-Version: 1.0 X-Received: by 10.182.20.195 with SMTP id p3mr14095329obe.42.1416864987794; Mon, 24 Nov 2014 13:36:27 -0800 (PST) In-Reply-To: References: <8761e8coo3.fsf@igel.home> Date: Mon, 24 Nov 2014 13:36:27 -0800 Message-ID: Subject: Re: [Patch] Add .size directives to x86_64 start.S, and possibly more From: Sterling Augustine To: "H.J. Lu" Cc: Andreas Schwab , GNU C Library , carlos@redhat.com On Mon, Nov 24, 2014 at 10:50 AM, H.J. Lu wrote: > Plain ENTRY is preferred if it works. I see no regressions on a "make check" using ENTRY and END. Assuming that is adequate testing, OK for trunk? 2014-11-24 Sterling Augustine * sysdeps/x86_64/start.S (_start): Use ENTRY and END macros. diff --git a/sysdeps/x86_64/start.S b/sysdeps/x86_64/start.S index e3d4ff8..97e972e 100644 --- a/sysdeps/x86_64/start.S +++ b/sysdeps/x86_64/start.S @@ -55,11 +55,7 @@ #include - .text - .globl _start - .type _start,@function -_start: - cfi_startproc +ENTRY (_start) /* Clearing frame pointer is insufficient, use CFI. */ cfi_undefined (rip) /* Clear the frame pointer. The ABI suggests this be done, to mark @@ -123,7 +119,7 @@ _start: #endif hlt /* Crash if somehow `exit' does return. */ - cfi_endproc +END (_start) /* Define a symbol for the first piece of initialized data. */ .data